https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: x11-wm/muffin-5.2.0 fails to compile. Discovered on: amd64 (internal ref: tinderbox) NOTE: This machine uses CLANG as a compiler and LLD as a linker
Created attachment 764067 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: ./configure: line 16552: gl_VISIBILITY: command not found clutter-main.c:3719:46: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
I don't use clang, and I'm not a C developer, so I'm not going to be any help. If you want this fixed, then you should probably file a bug upstream. I don't see much value in filing a bug myself if I'm only going to be copying messages back and forth. gl_VISIBILITY is already reported under Bug 741630, and will likely be "fixed" when muffin is rebased on a newer version of mutter and concerted to meson.
This was "fixed" in muffin 5.4.0, which migrated to meson. In the process, it changed from: clutter/configure.ac contains -Werror=format-nonliteral to clutter/meson.build contains -Wformat-nonliteral It also started only setting it if the buildtype is a developer buildtype or otherwise non-plain. The underlying issue is https://clang.llvm.org/docs/AttributeReference.html#format clang implements this slightly different from GCC, we have the va_list case here but no declared __attribute__. Anyways, it won't fail to build with clang anymore unless you bring your own CFLAGS to trigger it. Back in muffin 5.2.0, we could also have passed --disable-Werror to prevent this from halting the build!
Oops, didn't see the recent comment, sorry
Upstream report for reference https://github.com/linuxmint/muffin/issues/703 Unless you think I should close that WRT the comments about build config changes in meson.
It's still an upstream issue, we just cannot hit it in gentoo packaging unless someone both overrides EMESON_BUILDTYPE and uses package.env to set MYMESONARGS="-Dwerror=true". So I don't think we need to track it anymore.
