Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832446 - rsync mirrors have stale file metadata/install-qa-check.d/60distutils-use-setuptools
Summary: rsync mirrors have stale file metadata/install-qa-check.d/60distutils-use-set...
Status: CONFIRMED
Alias: None
Product: Mirrors
Classification: Unclassified
Component: Server Problem (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mirror Admins
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-31 19:55 UTC by Mike Gilbert
Modified: 2022-02-01 18:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2022-01-31 19:55:22 UTC
metadata/install-qa-check.d/60distutils-use-setuptools was removed from gentoo.git a couple of weeks ago.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f344326fa3c3653d85acf12bf053bfd98f354c56

It appears this file is still being distributed on rsync mirrors. I am using rsync.namerica.gentoo.org.
Comment 1 Mike Gilbert gentoo-dev 2022-01-31 20:12:00 UTC
I suspect this problem is this filter on line 128 of gen-rsync.sh.

https://gitweb.gentoo.org/infra/mastermirror-scripts.git/tree/rsync-gen.sh#n128

This prevents all files from being deleted from metatdata/.
Comment 2 Ken Rushia 2022-01-31 20:28:26 UTC
For the record this resulted in me filing a bunch of new bugs against bug 812431 before the nice folks in #gentoo-python let me know that this file isn't supposed to exist anymore. I'm now curious as to the nature of this, and whether users need to worry about rsync not matching git.

Confirmed with turnstone.gentoo.org
Comment 3 Ken Rushia 2022-01-31 20:50:46 UTC
The repoman files shouldn't be there either, but they are.

https://gitweb.gentoo.org/repo/gentoo.git/commit/metadata?id=f62e76a1e0202dcf55faa2b0fd9b21a1cd184dc8
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-01-31 20:54:26 UTC
(In reply to Ken Rushia from comment #2)
> For the record this resulted in me filing a bunch of new bugs against bug
> 812431 before the nice folks in #gentoo-python let me know that this file
> isn't supposed to exist anymore. I'm now curious as to the nature of this,
> and whether users need to worry about rsync not matching git.
> 
> Confirmed with turnstone.gentoo.org

See floppym's comment. In the private #gentoo-infra channel, I also said:
[20:16:55]  <@sam_> I suspect we can change it to just preserve metadata/md5-cache/* (the comment is outdated?)
[20:17:08]  <@sam_> I don't want to touch it without an ack from antarus or robbat2 though given I'm new.

(In reply to Ken Rushia from comment #3)
> The repoman files shouldn't be there either, but they are.
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> metadata?id=f62e76a1e0202dcf55faa2b0fd9b21a1cd184dc8

This will be addressed when we fix this issue as it's just a too-far glob.
Comment 5 Mike Gilbert gentoo-dev 2022-02-01 01:29:27 UTC
It looks like this glob was introduced in this commit:

https://gitweb.gentoo.org/infra/mastermirror-scripts.git/commit/?id=ec941f48d43133d34b292eddffa80a45cb880953

CC: dwfreed

Protecting everything under metadata/ by default seems like a bad approach. What specific files do we actually need to protect?
Comment 6 Larry the Git Cow gentoo-dev 2022-02-01 01:37:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46380b361bcbb28aa3a20fb0e9bc8dc97711b432

commit 46380b361bcbb28aa3a20fb0e9bc8dc97711b432
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-02-01 01:35:13 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-02-01 01:35:13 +0000

    metadata/install-qa-check.d: add stub for 60distutils-use-setuptools
    
    Work around broken rsync master script.
    
    Bug: https://bugs.gentoo.org/832446
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 metadata/install-qa-check.d/60distutils-use-setuptools | 2 ++
 1 file changed, 2 insertions(+)
Comment 7 Mike Gilbert gentoo-dev 2022-02-01 18:04:10 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77eda6e1796645fe2fe6609f7932ab64196240de

commit 77eda6e1796645fe2fe6609f7932ab64196240de
Author: Michał Górny <mgorny@gentoo.org>
Date:   Tue Feb 1 17:19:53 2022 +0100

    Try allowing removal of metadata/install-qa-check.d

    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 rsync-gen.sh | 1 +
 1 file changed, 1 insertion(+)
Comment 8 Larry the Git Cow gentoo-dev 2022-02-01 18:19:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=924aca491d65f3857f3bb335a97e460d099ffba1

commit 924aca491d65f3857f3bb335a97e460d099ffba1
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-02-01 18:18:45 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-02-01 18:19:29 +0000

    metadata/install-qa-check.d: drop 60distutils-use-setuptools again
    
    Bug: https://bugs.gentoo.org/832446
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 metadata/install-qa-check.d/60distutils-use-setuptools | 2 --
 1 file changed, 2 deletions(-)