Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 831044 - media-libs/xvid-1.3.7: replaces -mcpu with -mtune, leading to build failure.
Summary: media-libs/xvid-1.3.7: replaces -mcpu with -mtune, leading to build failure.
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-12 02:41 UTC by Georgy Yakovlev
Modified: 2024-08-19 01:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2022-01-12 02:41:05 UTC
so build/generic/configure:5025:

has this code (in couple of places)

CFLAGS=`echo $CFLAGS | sed s,"-mcpu","-mtune",g`


and it replaces valid -mcpu with -mtune which does not support all same options

on arm64 it's perfectly legal to specify CPU crypto extention support like this


-mcpu=cortex-a72.cortex-a53+crypto

but xvid replaces -mcpu with -tune where it's not legal

cc1: error: unknown value 'cortex-a72.cortex-a53+crypto' for '-mtune' ; did you mean 'cortex-a72.cortex-a53'?

so basically it bails out if it sees the +crypto part.


source is here
http://websvn.xvid.org/cvs/viewvc.cgi/tags/release-1_3_7/xvidcore/build/generic/configure.in?view=markup

maybe let's just rip it out?
Comment 1 David Racine 2024-04-04 23:17:54 UTC
I have a fix in my personal overlay:
https://github.com/bassdr/gentoo-local-overlay/tree/master/media-libs/xvid

I remove the mcpu -> mtunes replacement completely, and it just works.
Comment 2 Larry the Git Cow gentoo-dev 2024-08-19 01:17:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6772974ec4b3250f18dfaf2c142c8d439335e4a3

commit 6772974ec4b3250f18dfaf2c142c8d439335e4a3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-08-19 01:16:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-08-19 01:17:19 +0000

    media-libs/xvid: disable assembly
    
    There's a handful of very old asm impls in here for mmx+sse2 but they're
    non-PIC and unlikely to be worth it these days.
    
    Bug: https://bugs.gentoo.org/421841
    Bug: https://bugs.gentoo.org/831044
    Bug: https://bugs.gentoo.org/858431
    Closes: https://bugs.gentoo.org/258804
    Closes: https://bugs.gentoo.org/926543
    Closes: https://bugs.gentoo.org/937019
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/xvid/xvid-1.3.7-r2.ebuild | 69 ++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)