Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830990 - >=www-client/chromium-97: can't attach tab to window or move tab window horizontaly
Summary: >=www-client/chromium-97: can't attach tab to window or move tab window horiz...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-11 07:41 UTC by Marco Genasci
Modified: 2022-06-01 09:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
chromium-97.0.4692.71-fix-attch-dragging-tab.patch (chromium-97.0.4692.71-fix-attch-dragging-tab.patch,2.63 KB, patch)
2022-01-12 12:44 UTC, Marco Genasci
Details | Diff
0001-X11-Fix-tag-dragging-in-Mutter-and-KWin.patch (0001-X11-Fix-tag-dragging-in-Mutter-and-KWin.patch,2.35 KB, patch)
2022-01-12 15:18 UTC, Marco Genasci
Details | Diff
0002-X11-Fix-tag-dragging-in-i3.patch (0002-X11-Fix-tag-dragging-in-i3.patch,1.41 KB, patch)
2022-01-12 15:18 UTC, Marco Genasci
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Genasci 2022-01-11 07:41:56 UTC
With chromium-97 is impossible to drag or attach tab to a existing window.

Upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1279532

Possible patches:
https://chromium-review.googlesource.com/c/chromium/src/+/3355376
https://chromium-review.googlesource.com/c/chromium/src/+/3355470

I will test the patches in the day and tomorrow I will know if they work.

Reproducible: Always
Comment 1 Marco Genasci 2022-01-12 12:43:54 UTC
I missed another patch [1], but now tabs works correctly.
I tested only in i3, a merged patch added as attachment.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3381679
Comment 2 Marco Genasci 2022-01-12 12:44:26 UTC
Created attachment 761970 [details, diff]
chromium-97.0.4692.71-fix-attch-dragging-tab.patch
Comment 3 Stephan Hartmann (RETIRED) gentoo-dev 2022-01-12 14:45:20 UTC
This needs to be splitted up. The first two are already part of dev channel (99.0.4818.0). The last one isn't in any official release yet.
Comment 4 Marco Genasci 2022-01-12 14:50:45 UTC
(In reply to Stephan Hartmann from comment #3)
> This needs to be splitted up. The first two are already part of dev channel
> (99.0.4818.0). The last one isn't in any official release yet.

Ok, but without the latest patch I can't work on i3.
Comment 5 Stephan Hartmann (RETIRED) gentoo-dev 2022-01-12 15:00:49 UTC
(In reply to Marco Genasci from comment #4)
> (In reply to Stephan Hartmann from comment #3)
> > This needs to be splitted up. The first two are already part of dev channel
> > (99.0.4818.0). The last one isn't in any official release yet.
> 
> Ok, but without the latest patch I can't work on i3.

We can add it. For M97 and M98 we need all three patches and for M99 we only need the last one. Maybe use the original patches from Gerrit.
Comment 6 Marco Genasci 2022-01-12 15:18:08 UTC
Created attachment 761972 [details, diff]
0001-X11-Fix-tag-dragging-in-Mutter-and-KWin.patch
Comment 7 Marco Genasci 2022-01-12 15:18:19 UTC
Created attachment 761973 [details, diff]
0002-X11-Fix-tag-dragging-in-i3.patch
Comment 8 Larry the Git Cow gentoo-dev 2022-01-12 18:53:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c33c6f564944ad947b8e736abc6cfe53708a49b6

commit c33c6f564944ad947b8e736abc6cfe53708a49b6
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2022-01-12 18:52:39 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2022-01-12 18:52:59 +0000

    www-client/chromium: dev channel bump to 99.0.4818.0
    
    Bug: https://bugs.gentoo.org/830990
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 www-client/chromium/Manifest                       |   2 +
 www-client/chromium/chromium-99.0.4818.0.ebuild    | 960 +++++++++++++++++++++
 .../files/chromium-97-fix-tag-dragging-i3.patch    |  35 +
 .../chromium/files/chromium-glibc-2.34-r1.patch    |  20 +
 4 files changed, 1017 insertions(+)
Comment 9 Larry the Git Cow gentoo-dev 2022-01-12 19:56:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=65d397e4463368cb67058b2c9ca56a2820a5bd77

commit 65d397e4463368cb67058b2c9ca56a2820a5bd77
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2022-01-12 19:55:20 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2022-01-12 19:56:10 +0000

    www-client/chromium: fix tag dragging (M97)
    
    Bug: https://bugs.gentoo.org/830990
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 ...2.71.ebuild => chromium-97.0.4692.71-r1.ebuild} |  2 +
 .../files/chromium-97-fix-tag-dragging.patch       | 52 ++++++++++++++++++++++
 2 files changed, 54 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2022-01-12 21:27:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9061a510f7ca8f1fdcb1d885428ecc54606ae0b5

commit 9061a510f7ca8f1fdcb1d885428ecc54606ae0b5
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2022-01-12 21:26:56 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2022-01-12 21:27:13 +0000

    www-client/chromium: beta channel bump to 98.0.4758.48
    
    Closes: https://bugs.gentoo.org/830990
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 www-client/chromium/Manifest                                          | 2 +-
 .../{chromium-98.0.4758.9.ebuild => chromium-98.0.4758.48.ebuild}     | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)