Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830211 - metadata/xml-schema/metadata.xsd: support FTP urls
Summary: metadata/xml-schema/metadata.xsd: support FTP urls
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-12-29 07:46 UTC by Anna Vyalkova
Modified: 2022-01-23 15:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
metadata.xsd: Support FTP URLs (0001-metadata.xsd-Support-FTP-URLs.patch,1.04 KB, patch)
2022-01-22 12:21 UTC, Ulrich Müller
Details | Diff
metadata.xsd: Support FTP URLs (0001-metadata.xsd-Support-FTP-URLs.patch,1.03 KB, patch)
2022-01-23 15:31 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Vyalkova 2021-12-29 07:46:08 UTC
I'd like to add this URL as <changelog> to metadata.xml:

ftp://ftp.tin.org/pub/news/clients/tin/stable/CHANGES

I get this error:

(SCHEMAV_CVC_PATTERN_VALID) Element 'changelog': [facet 'pattern'] The value 'ftp://ftp.tin.org/pub/news/clients/tin/stable/CHANGES' is not accepted by the pattern '(mailto:[^@]+@[^.\s]+\.\S+|https?://\S+)'.

This changelog is not hosted anywhere on HTTP.
Comment 1 Mike Gilbert gentoo-dev 2021-12-29 16:27:29 UTC
The schema files do not have a dedicated maintainer, so there's really nobody I can assign this bug to.

You should propose this on the gentoo-dev mailing list instead.
Comment 2 Mike Gilbert gentoo-dev 2021-12-29 16:39:06 UTC
Assigning to infra since they "own" the git repo and no better option is available.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-12-29 20:14:36 UTC
Could you make a patch against data/xml-schema adding ftp to urlType, and send it to the gentoo-dev ml for review?  I don't think anybody's going to oppose but let's get some verbosity for this change.
Comment 4 Ulrich Müller gentoo-dev 2022-01-22 11:53:56 UTC
(In reply to Michał Górny from comment #3)
> Could you make a patch against data/xml-schema adding ftp to urlType, and
> send it to the gentoo-dev ml for review?  I don't think anybody's going to
> oppose but let's get some verbosity for this change.

Why does the schema define its own urlType? There's xs:anyURI which should cover all possibilities.
Comment 5 Ulrich Müller gentoo-dev 2022-01-22 12:21:10 UTC
Created attachment 763198 [details, diff]
metadata.xsd: Support FTP URLs

This seems to do the job.

Any comments? Otherwise I'll send it to the mailing list.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-01-22 12:25:04 UTC
(In reply to Ulrich Müller from comment #4)
> (In reply to Michał Górny from comment #3)
> > Could you make a patch against data/xml-schema adding ftp to urlType, and
> > send it to the gentoo-dev ml for review?  I don't think anybody's going to
> > oppose but let's get some verbosity for this change.
> 
> Why does the schema define its own urlType? There's xs:anyURI which should
> cover all possibilities.

Because we're dealing with specific tools that support only a subset of all URI schemes.
Comment 7 Ulrich Müller gentoo-dev 2022-01-23 15:31:13 UTC
Created attachment 763379 [details, diff]
metadata.xsd: Support FTP URLs

Slightly updated version, which has been posted for review:
https://archives.gentoo.org/gentoo-dev/message/cf3d9a3e6e605e9155e86b50a0a49fd8
Comment 8 Larry the Git Cow gentoo-dev 2022-01-23 15:34:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/data/xml-schema.git/commit/?id=d9fe77eac622d43629d9eb0aa79d9fa93c909cba

commit d9fe77eac622d43629d9eb0aa79d9fa93c909cba
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-01-22 12:16:07 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-01-22 12:28:37 +0000

    metadata.xsd: Support FTP URLs
    
    Base urlType on xs:anyURI. Slightly simplify the mailto syntax (a dot
    in the domain part is actually not required).
    
    Closes: https://bugs.gentoo.org/830211
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 metadata.xsd | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)