dev-python/gst-python: add python 3.10
@Andrew: dev-python/gst-python-1.8.4 works fine here with python 3.10 (see PR). In case didn't get it work please explain what fails with this PR...
(In reply to Thomas Bettler from comment #1) > @Andrew: > dev-python/gst-python-1.8.4 works fine here with python 3.10 (see PR). In > case didn't get it work please explain what fails with this PR... I tested yesterday and got a test failure with python 3.10
(In reply to Andrew Ammerlaan from comment #2) > I tested yesterday and got a test failure with python 3.10 OK, I can reproduce this with FEATURES=test May I ask if this will really be fixed with a bump to version 1.18.5 ? https://github.com/GStreamer/gst-python/compare/1.18.4...1.18.5 or https://github.com/GStreamer/gstreamer/compare/1.18.4...1.18.5 maybe I missed something? thanks for your input...
note to myself to keep the failing test GST_REGISTRY='/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10/testsuite/Test fundamentals.registry' GST_PLUGIN_PATH_1_0=/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10:/usr/lib64/gstreamer-1.0:/usr/lib64/gstreamer-1.0:/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10/plugin:/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite GST_PLUGIN_LOADING_WHITELIST=gstreamer:gst-plugins-base@/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10:gst-python@/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10 GST_OVERRIDE_SRC_PATH=/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/../gi/overrides GST_OVERRIDE_BUILD_PATH=/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10/testsuite/../gi/overrides MALLOC_PERTURB_=65 /usr/bin/python3.10 /var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4-python3_10/../gst-python-1.18.4/testsuite/runtests.py test_types.py ................. (python3.10:17261): GStreamer-CRITICAL **: 22:46:04.334: gst_value_set_fraction_range: assertion 'gst_util_fraction_compare (start->data[0].v_int, start->data[1].v_int, end->data[0].v_int, end->data[1].v_int) < 0' failed E........E...E. ====================================================================== ERROR: testGetValue (test_types.TestFractionRange) ---------------------------------------------------------------------- TypeError: 'float' object cannot be interpreted as an integer The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/test_types.py", line 190, in testGetValue st["range"] = Gst.FractionRange(Gst.Fraction(1, 30), Gst.Fraction(1, 2)) File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/../gi/overrides/Gst.py", line 310, in __setitem__ return self.set_value(key, value) SystemError: gi.FunctionInfo(set_value) returned a result with an exception set ====================================================================== ERROR: testGetValue (test_types.TestValueArray) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/test_types.py", line 304, in testGetValue st["array"] = Gst.ValueArray([Gst.Fraction(1, 30), Gst.Fraction(1, 2)]) File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/../gi/overrides/Gst.py", line 310, in __setitem__ return self.set_value(key, value) KeyError: 'Object is not compatible with Gst.ValueArray' ====================================================================== ERROR: testGetValue (test_types.TestValueList) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/test_types.py", line 339, in testGetValue st["framerate"] = Gst.ValueList([Gst.Fraction(1, 30), Gst.Fraction(1, 2)]) File "/var/tmp/portage/dev-python/gst-python-1.18.4/work/gst-python-1.18.4/testsuite/../gi/overrides/Gst.py", line 310, in __setitem__ return self.set_value(key, value) KeyError: 'Object is not compatible with Gst.ValueList' ---------------------------------------------------------------------- Ran 32 tests in 0.587s FAILED (errors=3)
There are zero functional changes between gst-python 1.18.4 and 1.18.5 (only commits are for the version increase and release notes for the whole gstreamer stack).
@Andrew: Thank you for your hint on the failing tests. I updated the PR with a patch. Test now works fine for me. Can you please recheck if the updated PR now passes for you too?
(In reply to Thomas Bettler from comment #6) > @Andrew: > Thank you for your hint on the failing tests. I updated the PR with a patch. > Test now works fine for me. > Can you please recheck if the updated PR now passes for you too? Awesome, all tests pass now. @Gstreamer Project what do you think? good to go?
*** Bug 832226 has been marked as a duplicate of this bug. ***
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1fdb5ab85428a9310e65d2bb95145390664984e2 commit 1fdb5ab85428a9310e65d2bb95145390664984e2 Author: Thomas Bettler <thomas.bettler@gmail.com> AuthorDate: 2021-12-12 18:57:28 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2022-01-28 20:57:36 +0000 dev-python/gst-python: add python 3.10 Closes: https://bugs.gentoo.org/829009 Closes: https://github.com/gentoo/gentoo/pull/23272 Signed-off-by: Thomas Bettler <thomas.bettler@gmail.com> Signed-off-by: Matt Turner <mattst88@gentoo.org> ...python-1.18.4-avoid-treating-float-as-int.patch | 86 ++++++++++++++++++++++ dev-python/gst-python/gst-python-1.18.4.ebuild | 4 + 2 files changed, 90 insertions(+)
Thanks a bunch!
