Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 825458 - =sys-devel/gcc-9.4.0: please backport recent musl support
Summary: =sys-devel/gcc-9.4.0: please backport recent musl support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: musl-porting
  Show dependency tree
 
Reported: 2021-11-21 07:54 UTC by tt_1
Modified: 2021-11-21 14:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2021-11-21 07:54:30 UTC
I still can't update beyond gcc-9 because there are two bugs introduced with gcc-10 for me, and since you already deleted any gcc related stuff from the musl overlay please be so kind to upload the patch tarball. Thank you.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-21 07:58:05 UTC
What are the bugs with GCC 10 you're hitting? GCC 9 is nearly out of support.

Note that gcc 9 was not in the overlay at the point I removed it from ::musl: https://github.com/gentoo/musl/commit/705fa69940aa50422a3fe98729d5a8bfc4a011f9.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-21 07:59:58 UTC
(It'd also be useful if you could let me know exactly which patches you've been using all this time, if you're still using GCC 9?)
Comment 3 tt_1 2021-11-21 08:09:12 UTC
https://bugs.gentoo.org/724314 of course, and an yet unreported arm bug. 

it seems low hanging fruit to me to add the tarball. 

this is the old code from gcc-9.4.0:

> src_prepare() {
> 	toolchain_src_prepare
> 
> 	if use elibc_musl || [[ ${CATEGORY} = cross-*-musl* ]]; then
> 		eapply "${FILESDIR}"/6.3.0/cpu_indicator.patch
> 		eapply "${FILESDIR}"/7.1.0/posix_memalign.patch
> 		case $(tc-arch) in
> 			amd64|arm64|ppc64) eapply "${FILESDIR}"/9.3.0/gcc-pure64.patch ;;
> 		esac
> 	fi
> 
> 	eapply_user
> }
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-21 08:31:18 UTC
(In reply to tt_1 from comment #3)
> https://bugs.gentoo.org/724314 of course, and an yet unreported arm bug. 
> 

Right. I mean, we're still not sure if that's actually a GCC bug or something in hardware, but in any case, fair enough.

You should really get a move on with reporting whatever this ARM bug is though. The more time goes on, the harder it's going to be to figure out where it was introduced.

> it seems low hanging fruit to me to add the tarball. 
> 

Sure, I'm not against it. It just read a bit like what we did somehow changed the situation when it hasn't really.

> this is the old code from gcc-9.4.0:
> 
> > src_prepare() {
> > 	toolchain_src_prepare
> > 
> > 	if use elibc_musl || [[ ${CATEGORY} = cross-*-musl* ]]; then
> > 		eapply "${FILESDIR}"/6.3.0/cpu_indicator.patch
> > 		eapply "${FILESDIR}"/7.1.0/posix_memalign.patch
> > 		case $(tc-arch) in
> > 			amd64|arm64|ppc64) eapply "${FILESDIR}"/9.3.0/gcc-pure64.patch ;;
> > 		esac
> > 	fi
> > 
> > 	eapply_user
> > }

Thanks, I'll look at it later.
Comment 5 tt_1 2021-11-21 08:58:00 UTC
you will propably have to use the older posix_memalign patch, take way back machine for a shortcut: 

https://github.com/gentoo/musl/tree/3f5f325fb24b120315f6b523d754930a116935dd/sys-devel/gcc/files/7.1.0
Comment 6 Larry the Git Cow gentoo-dev 2021-11-21 14:14:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cfec3b98f2821652f521441da68f6e109f77b5aa

commit cfec3b98f2821652f521441da68f6e109f77b5aa
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-11-21 14:13:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-11-21 14:13:57 +0000

    sys-devel/gcc: add musl support to 9.4.0
    
    Closes: https://bugs.gentoo.org/825458
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/features/musl/package.mask | 4 ++--
 sys-devel/gcc/Manifest              | 1 +
 sys-devel/gcc/gcc-9.4.0.ebuild      | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)