Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 824830 - media-gfx/apngasm requires media-libs/libpng[apng]
Summary: media-gfx/apngasm requires media-libs/libpng[apng]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2022-01-12
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 824018
  Show dependency tree
 
Reported: 2021-11-19 12:14 UTC by Michał Górny
Modified: 2021-12-22 20:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-19 12:14:29 UTC
This package seems to depend on APNG-patched version of media-libs/libpng.  These patches have been rejected upstream and are known to break WebKit.  Please fix the package to work without custom patching.
Comment 1 Larry the Git Cow gentoo-dev 2021-12-13 20:24:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7127427f605ccfa63a432c72dcb45a5a0fb21a1

commit c7127427f605ccfa63a432c72dcb45a5a0fb21a1
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-12-13 20:24:22 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-12-13 20:24:54 +0000

    package.mask: Last rite media-gfx/apngasm
    
    Bug: https://bugs.gentoo.org/824830
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Nikita Zlobin 2021-12-21 18:03:40 UTC
Interesting finding. Description for libpng[apng] flag may need more clear note about such possible breakages as with webkit.

Some more packages depend on same use with system-png:
{thunderbird,firefox,seamonkey} [system-png]
(may be system-png should be masked until those are ok)

Though e.g. chromium[system-png] requires apng off.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-12-21 18:04:53 UTC
(In reply to Nikita Zlobin from comment #2)
> Interesting finding. Description for libpng[apng] flag may need more clear
> note about such possible breakages as with webkit.
> 

Not a bad idea.

> Some more packages depend on same use with system-png:
> {thunderbird,firefox,seamonkey} [system-png]
> (may be system-png should be masked until those are ok)
> 
> Though e.g. chromium[system-png] requires apng off.

Yeah, precisely because of this (see the bug this blocks).
Comment 4 Larry the Git Cow gentoo-dev 2021-12-22 20:25:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8a0601218b33c6cf81039017917e1449d415cda

commit e8a0601218b33c6cf81039017917e1449d415cda
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2021-12-22 20:24:23 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2021-12-22 20:25:02 +0000

    media-gfx/apngasm: bump to 3.1.10
    
    Bug: https://bugs.gentoo.org/824830
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 media-gfx/apngasm/Manifest                         |  1 +
 media-gfx/apngasm/apngasm-3.1.10.ebuild            | 40 ++++++++++++++++
 .../apngasm/files/apngasm-3.1.10-static.patch      | 55 ++++++++++++++++++++++
 3 files changed, 96 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa5bd0d14d5179a2306805abe125e7350a417cc0

commit fa5bd0d14d5179a2306805abe125e7350a417cc0
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2021-12-22 20:23:14 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2021-12-22 20:25:01 +0000

    media-gfx/apngasm: remove apng dependency
    
    The bundled libpng copy isn't patched for apng as well.
    
    Bug: https://bugs.gentoo.org/824830
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 media-gfx/apngasm/{apngasm-2.91.ebuild => apngasm-2.91-r1.ebuild} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-12-22 20:27:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83bccb184d3d764c03f5b019c50e646095df893f

commit 83bccb184d3d764c03f5b019c50e646095df893f
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2021-12-22 20:26:38 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2021-12-22 20:27:39 +0000

    package.mask: drop media-gfx/apngasm mask
    
    Bug: https://bugs.gentoo.org/824830
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)