Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 820437 - net-libs/webkit-gtk: fails to build (InspectorCanvasAgent.h:88:25: error: ‘Frame’ has not been declared)
Summary: net-libs/webkit-gtk: fails to build (InspectorCanvasAgent.h:88:25: error: ‘Fr...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: CVE-2021-30818, CVE-2021-30823, CVE-2021-30846, CVE-2021-30848, CVE-2021-30849, CVE-2021-30851, CVE-2021-30884, CVE-2021-30888, CVE-2021-30889, CVE-2021-30897, WSA-2021-0006
  Show dependency tree
 
Reported: 2021-10-27 04:01 UTC by Sam James
Modified: 2022-01-03 03:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.bz2 (build.log.bz2,282.06 KB, application/x-bzip2)
2021-10-27 04:01 UTC, Sam James
Details
patch (InspectorCanvasAgent-declare-class-Frame.patch,476 bytes, patch)
2021-11-28 18:32 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 04:01:44 UTC
Created attachment 746907 [details]
build.log.bz2

# these two seemed to have the same 'error:' string in logs
# 6365:/var/tmp/portage/net-libs/webkit-gtk-2.34.1/work/webkitgtk-2.34.1/Source/WebCore/inspector/agents/InspectorCanvasAgent.h:88:25: error: ‘Frame’ has not been declared
# 6368:/var/tmp/portage/net-libs/webkit-gtk-2.34.1/work/webkitgtk-2.34.1/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:365:6: error: no declaration matches ‘void WebCore::InspectorCanvasAgent::frameNavigated(WebCore::Frame&)’
USE='X avif egl -examples -gamepad -geolocation -gles2-only -gnome-keyring gstreamer -gtk-doc introspection jpeg2k -jumbo-build -lcms -libnotify -opengl spell -wayland' failed for =net-libs/webkit-gtk-2.34.1
    log has been saved as /root/logs/net-libs_webkit-gtk-2.34.1_use_56Y7W

USE='-X -avif egl examples -gamepad geolocation -gles2-only -gnome-keyring gstreamer -gtk-doc introspection -jpeg2k -jumbo-build -lcms -libnotify -opengl -spell wayland' failed for =net-libs/webkit-gtk-2.34.1
    log has been saved as /root/logs/net-libs_webkit-gtk-2.34.1_use_TiJPk

----

Portage 3.0.28 (python 3.9.7-final-0, default/linux/arm64/17.0/desktop/gnome/systemd, gcc-11.2.0, glibc-2.33-r7, 5.10.38-gentoo-dist aarch64)
=================================================================
System uname: Linux-5.10.38-gentoo-dist-aarch64-with-glibc2.33
KiB Mem:   262984492 total, 156657164 free
KiB Swap:    9767620 total,   9767620 free
Timestamp of repository gentoo: Mon, 25 Oct 2021 13:30:01 +0000
Head commit of repository gentoo: a1acbd9e3a9b88934369a089be5c345b8b96fda7
sh bash 5.1_p8
ld GNU ld (Gentoo 2.37_p1 p0) 2.37
ccache version 4.4.2 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-lang/perl:            5.34.0-r3::gentoo
dev-lang/python:          3.9.7_p1::gentoo, 3.10.0_p1::gentoo
dev-lang/rust-bin:        1.56.0::gentoo
dev-util/ccache:          4.4.2::gentoo
dev-util/cmake:           3.21.3::gentoo
sys-apps/baselayout:      2.8::gentoo
sys-apps/sandbox:         2.27::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.5::gentoo
sys-devel/binutils:       2.37_p1::gentoo
sys-devel/gcc:            11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.14::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

ACCEPT_KEYWORDS="arm64 ~arm64"
ACCEPT_LICENSE="*"
CBUILD="aarch64-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="aarch64-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going=y --deep --complete-graph"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa arm64 bluetooth branding bzip2 cairo cdda cdr cli colord crypt cups dbus dri dts dvdr eds emboss encode evo exif flac fortran gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gui iconv icu introspection ipv6 jpeg lcms libglvnd libnotify libsecret libtirpc mad mng mp3 mp4 mpeg nautilus ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds pulseaudio qt5 readline sdl seccomp spell split-usr ssl startup-notification svg sysprof systemd tcpd tiff tracker truetype udev udisks unicode upower usb vorbis wayland wxwidgets x264 xattr xcb xml xv xvid zlib" ADA_TARGET="gnat_2019" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_ARM="edsp thumb thumb2 v4 v5 v6 v7 v8 vfp vfp-d32 vfpv3 vfpv4" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Comment 1 Matt Whitlock 2021-11-28 18:32:11 UTC
Created attachment 756857 [details, diff]
patch

This patch fixes the build for me. No idea how webkit-gtk builds for anyone without it.
Comment 2 Mart Raudsepp gentoo-dev 2021-12-17 06:48:14 UTC
(In reply to Matt Whitlock from comment #1)
> This patch fixes the build for me. No idea how webkit-gtk builds for anyone
> without it.

USE=jumbo-build glues different source files together, so the compiler sees them together as a single .cpp compilation unit, and something glued in front probably has it forward-declared already
Comment 3 Dennis Nezic 2021-12-24 13:52:32 UTC
Confirmed with 2.34.2. Very frustrating. Thanks for the patch Matt!

(Modern bloat-browsers are a nightmare!)
Comment 4 Larry the Git Cow gentoo-dev 2022-01-02 22:46:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=55e70521884cf6143a68a7ead6f65095887f9906

commit 55e70521884cf6143a68a7ead6f65095887f9906
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2022-01-02 22:34:53 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2022-01-02 22:44:13 +0000

    net-libs/webkit-gtk: fix build with USE=-jumbo-build
    
    Thanks-to: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/820437
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 .../webkit-gtk/files/2.34.3-non-jumbo-fix.patch    | 43 ++++++++++++++++++++++
 net-libs/webkit-gtk/webkit-gtk-2.34.3.ebuild       |  1 +
 2 files changed, 44 insertions(+)
Comment 5 Georgy Yakovlev archtester gentoo-dev 2022-01-03 01:44:23 UTC
looks like patch breaks jumbo-build though

In file included from /var/tmp/portage/net-libs/webkit-gtk-2.34.3/work/webkit-gtk-2.34.3_build/WebCore/DerivedSources/unified-sources/UnifiedSource-950a39b6-36.cpp:1:
/var/tmp/portage/net-libs/webkit-gtk-2.34.3/work/webkitgtk-2.34.3/Source/WebCore/html/track/InbandTextTrack.cpp:36:10: fatal error: TextTrackClient.h: No such file or directory
   36 | #include "TextTrackClient.h"
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
Comment 6 Georgy Yakovlev archtester gentoo-dev 2022-01-03 02:03:11 UTC
there's simply no TextTrackClient.h in the source
trying a revert for 2.34.3-non-jumbo-fix.patch now.
Comment 7 Georgy Yakovlev archtester gentoo-dev 2022-01-03 02:28:01 UTC
re-closing in favour of 820437
Comment 8 Larry the Git Cow gentoo-dev 2022-01-03 03:00:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4329f278bbb89c1661779e72fe04b46aebc8404f

commit 4329f278bbb89c1661779e72fe04b46aebc8404f
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2022-01-03 02:38:56 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2022-01-03 02:42:49 +0000

    net-libs/webkit-gtk: remove TextTrackClient.h include from the 2.34.3
    
    looks like this hunk got here by mistake.
    There's no such header in 2.34.3 source.
    
    Bug: https://bugs.gentoo.org/820437
    Closes: https://bugs.gentoo.org/830483
    Acked-by: Sam James <sam@gentoo.org>
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-libs/webkit-gtk/files/2.34.3-non-jumbo-fix.patch | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)