Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 820407 - sys-apps/sandbox-2.26: ptrace main loop does not resume correctly after passing signals through (causes dev-lang/crystal-1.2.1 to hang)
Summary: sys-apps/sandbox-2.26: ptrace main loop does not resume correctly after passi...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Sandbox (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sandbox Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 910332
  Show dependency tree
 
Reported: 2021-10-26 19:01 UTC by James Cloos
Modified: 2023-07-14 10:44 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_820407.txt,3.55 KB, text/plain)
2021-10-27 14:16 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Cloos 2021-10-26 19:01:15 UTC
compile dies (or locks up) with:

>>> Compiling source in /var/tmp/portage/dev-lang/crystal-1.1.1/work/crystal-1.1.1 ...
make -j12 release=1 progress=true stats=1 threads=12 verbose=1 CC=x86_64-pc-linux-gnu-gcc CXX=x86_64-pc-linux-gnu-g++ AR=x86_64-pc-linux-gnu-ar LLVM_CONFIG=/usr/lib/llvm/11/bin/llvm-config PATH=/var/tmp/portage/dev-lang/crystal-1.1.1/work/crystal-1.1.1-1/bin:/usr/lib/portage/python3.9/ebuild-helpers/xattr:/usr/lib/portage/python3.9/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/share/bcc/tools:/usr/lib/llvm/11/bin:/usr/lib/llvm/13/bin:/usr/lib/llvm/11/bin:/usr/lib/llvm/12/bin:/opt/eagle/bin:/usr/lib/hip/bin CRYSTAL_PATH=src CRYSTAL_CONFIG_VERSION=1.1.1 CRYSTAL_CONFIG_PATH=lib:/usr/lib64/crystal
Using /usr/lib/llvm/11/bin/llvm-config [version=11.1.0]
x86_64-pc-linux-gnu-g++ -c -Os -ftree-vectorize -pipe -march=native  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc -I/usr/lib/llvm/11/include -std=c++14    -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
CRYSTAL_CONFIG_LIBRARY_PATH="" CRYSTAL_CONFIG_BUILD_COMMIT="" SOURCE_DATE_EPOCH="1635274050" ./bin/crystal build --release --stats --progress --threads 12 --link-flags="-Wl,-O1 -Wl,--as-needed" --verbose  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
CRYSTAL_PATH env variable does not contains /var/tmp/portage/dev-lang/crystal-1.1.1/work/crystal-1.1.1/src


nothing occurs after the 'CRYSTAL_PATH env variable does not contains' output, nor does it return to the shell.

tried on multiple ~amd64 boxen.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 05:52:18 UTC
I suspect by now you know that we need the full build.log (up to the point of hang) and emerge --info.
Comment 2 James Cloos 2021-10-27 12:00:08 UTC
if you would have read it, you may have noticed that that *is* the full build log.

and --info includes private information which *never* should be public.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 12:01:52 UTC
(In reply to James Cloos from comment #2)
> if you would have read it, you may have noticed that that *is* the full
> build log.
> 

I did read and there’s information at the beginning missing.

> and --info includes private information which *never* should be public.

Feel free to:
1. List the actual issues;
2. Redact anything problematic.
Comment 4 James Cloos 2021-10-27 13:15:29 UTC
i already did list *all of* theactual issues.

stop being an ass about it.

any attempt to merge it will show the same result.  at least on ~amd64, as i wrote.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 13:35:07 UTC
(In reply to James Cloos from comment #4)
> i already did list *all of* theactual issues.
> 

I meant with emerge --info so we can fix it.

> stop being an ass about it.
> 

There's no reason to be rude like this at all.

> any attempt to merge it will show the same result.  at least on ~amd64, as i
> wrote.

This is not a particularly informative bug report. It's a huge waste of time for me to have to ask arbitrary questions which may or may not be acceptable to you that would've been answered by just giving all the information I requested in the standard format.

For example, hangs are often related to sandbox version. I have no idea what sandbox version you have.

I have no idea which USE flags are enabled for Crystal. I have no idea if there's something obvious about your machine to you that doesn't apply to me.
Comment 6 Larry the Git Cow gentoo-dev 2021-10-27 14:14:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ada59ceaf9a86e0b136f35dc91f830c48973e4d

commit 4ada59ceaf9a86e0b136f35dc91f830c48973e4d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-10-27 14:13:54 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-10-27 14:14:38 +0000

    dev-lang/crystal: add 1.2.1
    
    Still hangs with FEATURES="sandbox usersandbox" but best to be trying
    with the latest version.
    
    Bug: https://bugs.gentoo.org/820407
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-lang/crystal/Manifest             |   2 +
 dev-lang/crystal/crystal-1.2.1.ebuild | 104 ++++++++++++++++++++++++++++++++++
 2 files changed, 106 insertions(+)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 14:16:06 UTC
Created attachment 746997 [details]
build.log


Portage 3.0.28 (python 3.10.0-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-11.2.0, glibc-2.34, 5.10.75-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-5.10.75-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.34
KiB Mem:    16365060 total,   3268756 free
KiB Swap:   25067512 total,  24674744 free
Timestamp of repository gentoo: Wed, 27 Oct 2021 13:51:38 +0000
Head commit of repository gentoo: e1ba4a498b0ab3aa5e7df42c77333b1266cc8eb5

Timestamp of repository kde: Sun, 24 Oct 2021 16:36:49 +0000
Head commit of repository kde: 5102652de8f29bfa82b2b992ed5258a7c6e7588a

Timestamp of repository qt: Thu, 21 Oct 2021 00:34:37 +0000
Head commit of repository qt: 898c77083ea7795a655a5c5c8c8c1dd3030366a4

Timestamp of repository steam-overlay: Sun, 24 Oct 2021 16:36:44 +0000
Head commit of repository steam-overlay: 022a274069862bab24ce4d1a83b6372eea5b3988

sh bash 5.1_p8
ld GNU ld (Gentoo 2.37_p1 p0) 2.37
ccache version 4.4.2 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-lang/perl:            5.34.0-r5::gentoo
dev-lang/python:          3.8.12_p1::gentoo, 3.9.7_p1::gentoo, 3.10.0_p1::gentoo
dev-lang/rust-bin:        1.56.0::gentoo
dev-util/ccache:          4.4.2::gentoo
dev-util/cmake:           3.21.3::gentoo
sys-apps/baselayout:      2.8::gentoo
sys-apps/sandbox:         2.27::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.5::gentoo
sys-devel/binutils:       2.37_p1::gentoo
sys-devel/gcc:            9.4.0::gentoo, 10.3.0-r2::gentoo, 11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.14::gentoo (virtual/os-headers)
sys-libs/glibc:           2.34::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: git://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c

sam_c
    location: /home/sam/git/overlay
    masters: gentoo
    eclass-overrides: sam_c

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --changed-deps-report=y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/ http://mirrors.gethosted.online/gentoo"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS="en en_GB"
MAKEOPTS="-j24"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cli crypt dbus declarative dist-kernel dri dts dvd dvdr emacs emboss encode exif f16c filecaps firewalld flac fma3 fortran gdbm gif gmp gpm graphite gtk gui hardened hunspell iconv icu ipv6 jit jpeg kde kdesu kipi kwallet lcms libglvnd libnotify libtirpc llvm-libunwind mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline sdl seccomp semantic-desktop sha spell split-usr sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd threads tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets wxwidgets x264 xattr xcb xml xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2019" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9 python3_10 python3_8" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 14:17:03 UTC
I can't actually strace the hanging crystal process:
# strace -p 3887446
strace: attach: ptrace(PTRACE_SEIZE, 3887446): Operation not permitted
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-27 14:18:44 UTC
(In reply to Sam James from comment #8)
> I can't actually strace the hanging crystal process:
> # strace -p 3887446
> strace: attach: ptrace(PTRACE_SEIZE, 3887446): Operation not permitted

USER         PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
[...]
root        2575  0.0  0.0   6952   336 ?        Ss   Oct25   0:00 sshd: /usr/sbin/sshd -D -e [listener] 0 of 10-100 startups
root     3711148  0.0  0.0   9072  1472 ?        Ss   11:21   0:00  \_ sshd: sam [priv]
sam      3711150  0.0  0.0   9072  1516 ?        S    11:21   0:01      \_ sshd: sam@pts/0,pts/7,pts/10
sam      3711151  0.0  0.0   9876   364 pts/0    Ss   11:21   0:00          \_ -bash
sam      3717202  0.0  0.0   8108   316 pts/0    S+   11:50   0:00          |   \_ screen -xR
sam      3774875  0.0  0.0  11500  4832 pts/7    Ss   13:44   0:00          \_ -bash
root     3884261  0.0  0.0  12988  4208 pts/7    S+   15:15   0:00          |   \_ sudo ebuild crystal-1.2.1.ebuild clean install
root     3884263  0.3  0.3 144812 60056 pts/7    SN+  15:15   0:00          |       \_ /usr/bin/python3.10 -b /usr/lib/python-exec/python3.10/ebuild crystal-1.2.1.ebuild clean install
root     3887311  0.0  0.0  16140  8836 pts/7    SN+  15:15   0:00          |           \_ /usr/bin/python3.10 /usr/lib/portage/python3.10/pid-ns-init 3887312
root     3887312  0.0  0.0  16280  8872 pts/9    SNs+ 15:15   0:00          |               \_ /usr/bin/python3.10 /usr/lib/portage/python3.10/pid-ns-init 250 250 250 18 0,1,2 /usr/bin/sandbox [dev-lang/crystal-1.2.1] sandbox /usr/lib/portage/python3.10/ebuild.sh compile
portage  3887316  0.0  0.0   2624  1452 pts/9    SN+  15:15   0:00          |                   \_ [dev-lang/crystal-1.2.1] sandbox /usr/lib/portage/python3.10/ebuild.sh compile
portage  3887317  0.0  0.0  12260  6028 pts/9    SN+  15:15   0:00          |                       \_ /bin/bash /usr/lib/portage/python3.10/ebuild.sh compile
portage  3887333  0.0  0.0  12388  5036 pts/9    SN+  15:15   0:00          |                           \_ /bin/bash /usr/lib/portage/python3.10/ebuild.sh compile
portage  3887338  0.0  0.0  10080  3684 pts/9    SN+  15:15   0:00          |                               \_ /bin/bash /usr/lib/portage/python3.10/ebuild-helpers/emake release=1 progress=true stats=1 threads=8 verbose=1 CC=x86_64-pc-linux-gnu-gcc CXX=x86_64-pc-linux-gnu-g++ AR=x86_64-pc-linux-gnu-ar LLVM_CONFIG=/usr/lib/llvm/13/bin/llvm-config PATH=/var/tmp/portage/dev-lang/crystal-1.2.1/work/crystal-1.2.1-1/bin:/usr/lib/portage/python3.10/ebuild-helpers/xattr:/usr/lib/portage/python3.10/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/13/bin:/usr/lib/llvm/13/bin:/usr/lib/llvm/12/bin CRYSTAL_PATH=src CRYSTAL_CONFIG_VERSION=1.2.1 CRYSTAL_CONFIG_PATH=lib:/usr/lib64/crystal
portage  3887340  0.1  0.0  17676 11604 pts/9    SN+  15:15   0:00          |                                   \_ make -j8 release=1 progress=true stats=1 threads=8 verbose=1 CC=x86_64-pc-linux-gnu-gcc CXX=x86_64-pc-linux-gnu-g++ AR=x86_64-pc-linux-gnu-ar LLVM_CONFIG=/usr/lib/llvm/13/bin/llvm-config PATH=/var/tmp/portage/dev-lang/crystal-1.2.1/work/crystal-1.2.1-1/bin:/usr/lib/portage/python3.10/ebuild-helpers/xattr:/usr/lib/portage/python3.10/ebuild-helpers:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/13/bin:/usr/lib/llvm/13/bin:/usr/lib/llvm/12/bin CRYSTAL_PATH=src CRYSTAL_CONFIG_VERSION=1.2.1 CRYSTAL_CONFIG_PATH=lib:/usr/lib64/crystal
portage  3887406  0.0  0.0   9676  3196 pts/9    SN+  15:15   0:00          |                                       \_ /bin/sh ./bin/crystal build --release --stats --progress --threads 8 --link-flags=-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 --verbose -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
portage  3887446  0.0  0.0  92416  9280 pts/9    SNl+ 15:15   0:00          |                                           \_ crystal build --release --stats --progress --threads 8 --link-flags=-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 --verbose -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
portage  3887462  0.0  0.0      0     0 pts/9    ZN+  15:15   0:00          |                                               \_ [ldd] <defunct>
Comment 10 SpanKY gentoo-dev 2021-10-27 16:43:42 UTC
(In reply to James Cloos from comment #4)

we have bug reporting requirements which include the full build log & emerge info.  if you can't follow them, then don't bother filing bugs.  we do not have the bandwidth to try and support every snowflake.
Comment 11 SpanKY gentoo-dev 2021-10-28 05:37:46 UTC
looks like the issue is due to my recent rewrite:
https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=e9946633344c34b295485130f8f0fceb10fedc96

the logic to pass signals through is slightly off ... we pass the signal through, but then don't restart the state machine correctly, and things go off into the weeds.

it shows up here because crystal statically links itself for some reason, and uses boehm-gc, and that lib explicitly probes its own memory map until it triggers a SIGSEGV.
Comment 12 Larry the Git Cow gentoo-dev 2021-10-28 07:14:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=a374b1f829a07cce3eb708f078a2a70f9bc4d975

commit a374b1f829a07cce3eb708f078a2a70f9bc4d975
Author:     Mike Frysinger <vapier@gentoo.org>
AuthorDate: 2021-10-28 05:49:33 +0000
Commit:     Mike Frysinger <vapier@gentoo.org>
CommitDate: 2021-10-28 05:49:33 +0000

    libsandbox: fix signal pass through with ptrace main loop
    
    When we're notified that the child has received a signal, we need to
    pass it through since we don't care about signals.  We did that, but
    using PTRACE_CONT which causes the process to just resume, and then
    we'd call PTRACE_SYSCALL on that resumed state.  When the pass thru
    logic was a signal handler, PTRACE_CONT was correct since it would
    come in while in the middle of PTRACE_SYSCALL, but after the rewrite
    of the main loop, it's now the wrong call.  Pass the signal back to
    the existing PTRACE_SYSCALL call so that we stay in the main loop
    and get notified on the next syscall event.
    
    Closes: https://bugs.gentoo.org/820407
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>

 libsandbox/trace.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 13 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-28 07:19:27 UTC
Thanks vapier!