Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 814827 - app-backup/rsnapshot: deletes backups, even if there is nothing to rotate
Summary: app-backup/rsnapshot: deletes backups, even if there is nothing to rotate
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: folajimi
Keywords: PATCH
Depends on:
Reported: 2021-09-25 17:08 UTC by cilly
Modified: 2023-02-08 04:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Patch - Debian Bug #901156 (rsnapshot-robust-debian_bug_#901156.patch,3.08 KB, patch)
2021-09-25 17:08 UTC, cilly
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cilly 2021-09-25 17:08:24 UTC
Created attachment 741294 [details, diff]
Patch - Debian Bug #901156

Please, apply the attached patch, to make rsnapshot more robust:

There is a bug with rsnapshot, see debian:

---- credits to go to: Osamu

Problem: the robustness of rsnapshot program under desktop environment
when cron is not always running and "beta" may be invoked consecutively
without invoking "alpha".

(I am using Debian/stable now but the version in testing/unstable is the same)

How to re-produce problem:

Let me present a simple manual invocation case as below (No

With /etc/rsnapshot.conf having:
retain  alpha   6
retain  beta    7
retain  gamma   4

Let's invoke:
 $ sudo rsnapshot alpha

Invoking this 6 times will create:

So far, this looks good. Then, let's invoke:
 $ sudo rsnapshot beta

Invoking this will create:

So far still good.  Let's suppose to invoke the following again and see
the result:
 $ sudo rsnapshot beta
/var/cache/rsnapshot/alpha.5 not present (yet), nothing to copy

This message is true but the result is a bit unexpected:

Why beta.0 is missing ???

What happens is delete and rotate actions for "beta" is performed then
it fails to move file from "alpha.5" to "beta.0".  Rotating without new
data added to "*.0" is bad.  It should not do this delete and rotate
actions if "alpha.5" isn't there.

I am afraid this problem may be the root cause of many unexpected
results under non-optimal invocation of rsnapshot.

Backup script should be robust ;-)

Solution proposal:

Let's check situation with:
 -d "$config_vars{'snapshot_root'}/$prev_interval.$prev_interval_max")
If not exist, "delete" and "rotate" should be skipped.

See attached patch file (patch -p0) for exact detail.

This may be better to be addressed by the upstream.


I reworked the patch (see attached), so it works with:

Comment 1 cilly 2021-09-25 18:31:27 UTC
One more thing: the patch works also on version 1.4.4 which isn't in the tree, yet.