Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 81155 - gaim should offer an useflag for being build with screensaver-extension or not
Summary: gaim should offer an useflag for being build with screensaver-extension or not
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All All
: High normal
Assignee: Gaim Bugs Crew
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-07 12:43 UTC by Lars Strojny
Modified: 2005-03-21 17:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Strojny 2005-02-07 12:43:43 UTC
Here is the patch:

diff -u /usr/portage/net-im/gaim/gaim-1.1.2.ebuild gaim-1.1.2-r1.ebuild
--- /usr/portage/net-im/gaim/gaim-1.1.2.ebuild  2005-02-06 12:12:54.000000000 +0100
+++ gaim-1.1.2-r1.ebuild        2005-02-07 15:19:28.427541496 +0100
@@ -11,7 +11,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="alpha amd64 arm hppa ia64 mips ppc ppc64 sparc x86"
-IUSE="nls perl spell nas cjk gnutls silc eds debug"
+IUSE="xscreensaver nls perl spell nas cjk gnutls silc eds debug"

 DEPEND=">=x11-libs/gtk+-2.0
        >=dev-libs/glib-2.0
@@ -26,7 +26,8 @@
        gnutls? ( net-libs/gnutls )
        !gnutls? ( >=dev-libs/nss-3.9.2-r2 )
        silc? ( >=net-im/silc-toolkit-0.9.12-r3 )
-       eds? ( gnome-extra/evolution-data-server )"
+       eds? ( gnome-extra/evolution-data-server )
+       xscreensaver? ( x11-misc/xscreensaver )"

 # List of plugins
 #      net-im/gaim-blogger
@@ -85,6 +86,7 @@
        [ "`gcc-version`" == "3.2" ] && filter-flags -msse2

        local myconf
+       use xscreensaver || myconf="${myconf} --disable-screensaver"
        use debug && myconf="${myconf} --enable-debug"
        use perl || myconf="${myconf} --disable-perl"
        use spell || myconf="${myconf} --disable-gtkspell"
Comment 1 Don Seiler (RETIRED) gentoo-dev 2005-02-07 12:53:53 UTC
A grand idea.

However currently xscreensaver isn't KEYWORDed for arm or mips.  CC'ing those arches to see if they can either add xscreensaver or put xscreensaver into use.mask for those arch profiles.
Comment 2 SpanKY gentoo-dev 2005-02-13 15:38:41 UTC
xscreensaver failed to build on my arm:
xscreensaver-getimage.c:58:42: gdk-pixbuf/gdk-pixbuf-xlib.h: No such file or dir
ectory

i feel like this is a bug in the DEPEND or something, but i really havent researched this failure at all
Comment 3 Don Seiler (RETIRED) gentoo-dev 2005-02-24 19:41:19 UTC
I fixed the gtk1/gdk-pixbuf dependency bug in xscreensaver-4.16.  I also added xscreensaver-4.20 which drops gtk1 support altogether (thank god).  Please re-test (both versions if you can) and keyword accordingly.
Comment 4 Don Seiler (RETIRED) gentoo-dev 2005-03-07 11:37:34 UTC
Re-pinging ARM and MIPS squads about this.
Comment 5 Stephen Becker (RETIRED) gentoo-dev 2005-03-07 12:25:59 UTC
I already told you I won't stable this on mips so quickly.  I need to explore the possibility of adding opengl to use.mask first, since the glx screensavers bring X down real quick.  However, doing this may remove functionality from stuff that does work in other packages.  What you need to do is just go ahead with your new useflag and then add it to the mips use.mask.
Comment 6 Don Seiler (RETIRED) gentoo-dev 2005-03-07 12:35:42 UTC
I didn't ask you to stable it.  It's not even keyworded at all.  That is what I'm asking about.

Masking in your profile works for me, if that is indeed what you'd like.
Comment 7 Stephen Becker (RETIRED) gentoo-dev 2005-03-07 12:37:52 UTC
xscreensaver-4.16.ebuild:KEYWORDS="x86 ppc sparc alpha amd64 ~ia64 hppa ppc64 ~mips"
xscreensaver-4.20.ebuild:KEYWORDS="~x86 ~ppc ~sparc ~alpha ~amd64 ~ia64 ~hppa ~ppc64 ~mips"


Could have fooled me.
Comment 8 Don Seiler (RETIRED) gentoo-dev 2005-03-07 12:43:12 UTC
Well then I'm an ass.

As such I'll remove the mips CC from this bug so my weak mind isn't so easily fooled in the future.

Thanks.
Comment 9 Don Seiler (RETIRED) gentoo-dev 2005-03-21 11:39:19 UTC
With vapier's OK I keyworded xscreensaver 4.16 and 4.20 in ~arm and added xscreensaver USE flag support in gaim-1.2.0-r1.