Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80760 - patch allowing transfig-3.2.4 to compile against gcc-4
Summary: patch allowing transfig-3.2.4 to compile against gcc-4
Status: RESOLVED DUPLICATE of bug 110948
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Philip Walls (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-04 11:28 UTC by Stéphane Gimenez
Modified: 2005-10-31 10:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
allows transfig-3.2.4 to compile against gcc-4 (tranfig-3.2.4-gcc4.patch,1.66 KB, patch)
2005-02-04 11:29 UTC, Stéphane Gimenez
Details | Diff
dirty patch for dirty makefile to make sure compilation fails if one subdir fails to compile (Makefile.patch,435 bytes, patch)
2005-06-15 12:10 UTC, Fabian Groffen
Details | Diff
changes made to make it compile on GCC 4 and fail as soon as one subdir fails (transfig-3.2.4-r1.ebuild.diff,929 bytes, patch)
2005-06-15 12:12 UTC, Fabian Groffen
Details | Diff
patch to the ebuild with includes the gcc4 patch and adds virtual/x11 dependency (ebuild.diff,934 bytes, patch)
2005-08-13 03:03 UTC, Fabian Groffen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Gimenez 2005-02-04 11:28:44 UTC
Hi, here's a patch which allows transfig-3.2.4 to compile against gcc-4.0
Ask me if you want me to forward this patch upstream.

Regards.
Comment 1 Stéphane Gimenez 2005-02-04 11:29:53 UTC
Created attachment 50366 [details, diff]
allows transfig-3.2.4 to compile against gcc-4
Comment 2 Fabian Groffen gentoo-dev 2005-06-15 12:07:42 UTC
surpisingly, the ebuild just continues and reports the merge TO BE SUCCESSFUL! 
This is however a bug in the Makefile generated and seems to be fixable by
patching the Makefile afterwards.  No idea whether this is generic.  It is
scary.  See attach 1 which follows this post.

using the patch supplied, the compilation runs further on GCC 4.0.0 OS X Tiger,
but make finally dies with:
/bin/sh: line 1: rman: command not found
make: *** [fig2dev.1.html] Error 127

I guess this should have been a dependency for OSX, as Gentoo Linux systems seem
to have this tool by default without having the rman ebuild installed actually.
 See separate bug for rman 3.1 compiles fine on OSX.

After applying the two patches, the ebuild finally compiled on OS X Portage. 
The ebuild diff is attached secondly below.  The assumed name for the originally
supplied patch is ${P}-gcc-4.0.patch = transfig-3.2.4-gcc-4.0.patch
Comment 3 Fabian Groffen gentoo-dev 2005-06-15 12:10:36 UTC
Created attachment 61295 [details, diff]
dirty patch for dirty makefile to make sure compilation fails if one subdir fails to compile

This patch makes sure the whole compilation fails if one subdir (fig2dev for
instance) fails, which happens on Portage OSX with GCC 4.0.  Before this patch
the ebuild just continues and reports build to be fine, while in fact the quite
important fig2dev tool is missing.
Comment 4 Fabian Groffen gentoo-dev 2005-06-15 12:12:26 UTC
Created attachment 61296 [details, diff]
changes made to make it compile on GCC 4 and fail as soon as one subdir fails

This patch shows the changes I had to make to get the ebuild to compile on
Portage OSX with GCC 4.0
Comment 5 Fabian Groffen gentoo-dev 2005-08-13 03:00:32 UTC
malverian,

the ebuild (transfig-3.2.4-r2) uses xmkmf and rman which is provided by X, hence
I added the dependency for virtual/x11

Are the changes to the ebuild okay with you (see next post with attach), and
would you like to check them in, or allow me to check them in?

Adding ppc-macos as this bug also solves compilation issue on OSX 10.4 (which
uses GCC4)
Comment 6 Fabian Groffen gentoo-dev 2005-08-13 03:03:02 UTC
Created attachment 65819 [details, diff]
patch to the ebuild with includes the gcc4 patch and adds virtual/x11 dependency

the used patch is the one supplied by gim initially.
Comment 7 Fabian Groffen gentoo-dev 2005-10-31 10:32:28 UTC
this is solved now.

*** This bug has been marked as a duplicate of 110948 ***