Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 804193 - sys-apps/openrc rc_cgroup_cleanup does not work
Summary: sys-apps/openrc rc_cgroup_cleanup does not work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-25 16:30 UTC by wolf+gentoo
Modified: 2021-08-20 17:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wolf+gentoo 2021-07-25 16:30:04 UTC
It looks like there is a typo in https://github.com/OpenRC/openrc/blob/master/sh/rc-cgroup.sh#L222 , it should be `${cgroup_pids}` instead of the current  version with `()`.

Current code fail on service stop with `cgroup_pids: not found` (since command/function of that name indeed does not exist).

Also, since I'm already reporting this:

    ebegin "starting cgroups cleanup"

The message starts with lowercase `s`, but other messages (`Stopping ...`) are with capital one. It looks out of place when running restart for example:

     * Stopping xx ...                                    [ ok ]
     * starting cgroups cleanup ...                       [ ok ]
     * Starting xx ...                                    [ ok ]

If someone will be touching the file anyway it could be adjusted to `S`.
Comment 1 William Hubbs gentoo-dev 2021-08-20 17:32:26 UTC
This is fixed in 0.43.5.