Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 798831 - net-fs/nfs-utils cleanup / bad flag logic
Summary: net-fs/nfs-utils cleanup / bad flag logic
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2021-06-26 19:28 UTC by tdr
Modified: 2024-01-25 11:08 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nfs-utils-2.5.4.ebuild.patch (nfs-utils-2.5.4.ebuild.patch,3.05 KB, patch)
2021-06-26 21:10 UTC, Justin Keogh
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tdr 2021-06-26 19:28:11 UTC
net-fs/nfs-utils-2.5.3-r1 
   contains line:  
      newinitd "${FILESDIR}"/nfsmount.initd-1.3.1 nfsmount # Nuke after 2015/08/01
   is that still needed?

net-fs/nfs-utils-2.5.3-r1 + net-fs/nfs-utils-2.5.4 
   both contain:
                if use nfsv4 && use nfsidmap ; then
                insinto /etc
                doins support/nfsidmap/idmapd.conf
 
   should require nfsidmap + one or more of nfs4 nfsv41 to provide idmapd.conf


    


Reproducible: Always

Actual Results:  
Without idmapd.conf, the nfs server won't start for v4.1 nfs
Adding nfsv4 when only need nfsv41 starts normal:

2021-06-26_13:29:40 root@workbox ~ $ /etc/init.d/nfs restart
 * Caching service dependencies ...                                                                                                                                                                                                                                        [ ok ]
 * Starting NFS statd ...                                                                                                                                                                                                                                                  [ ok ]
 * Setting up RPC pipefs ...                                                                                                                                                                                                                                               [ ok ]
 * Starting idmapd ...                                                                                                                                                                                                                                                     [ ok ]
 * Mounting nfsd filesystem in /proc ...                                                                                                                                                                                                                                   [ ok ]
 * Starting NFS mountd ...                                                                                                                                                                                                                                                 [ ok ]
 * Starting NFS daemon ...                                                                                                                                                                                                                                                 [ ok ]

Without, idmap service not found/fucntionable
 * Starting NFS smnotify ...  

Expected Results:  
normal startup
Comment 1 Justin Keogh 2021-06-26 21:10:38 UTC
Created attachment 719487 [details, diff]
nfs-utils-2.5.4.ebuild.patch

Removed the stub rc script from bug #537996

Made +nfsv4 and +nfsv41 symmetric, which fixes the case where +nfsidmap -nfsv4 +nfsv41 would not result in /etc/init.d/rpc.idmapd being created
Comment 2 iroshan 2021-06-27 06:54:26 UTC Comment hidden (spam)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-23 15:43:39 UTC
commit cda6f318133f1fc45ca306d0991ff1dfe9a5efda
Author: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
Date:   Tue Jan 23 15:45:28 2024 +0100

    net-fs/nfs-utils: simplify NFS versions handling

    Closes: https://github.com/gentoo/gentoo/pull/34977
    Signed-off-by: Hanabishi <13597663+HanabishiRecca@users.noreply.github.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

This improved the situation quite a bit, and soap is going to remove nfsidmap as a USE too.
Comment 4 Larry the Git Cow gentoo-dev 2024-01-25 11:08:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c54cb04aac675eebda4970990d7fd073f0d56e40

commit c54cb04aac675eebda4970990d7fd073f0d56e40
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2024-01-25 11:07:48 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2024-01-25 11:07:48 +0000

    net-fs/nfs-utils: remove USE={idmap,nfsdcld}
    
    * The absence of idmap leads to obscure issues on NFSv4.
    
    Closes: https://github.com/gentoo/gentoo/pull/34988
    Bug: https://bugs.gentoo.org/798831
    Bug: https://bugs.gentoo.org/914203
    Signed-off-by: David Seifert <soap@gentoo.org>

 ...s-2.6.4-r2.ebuild => nfs-utils-2.6.4-r3.ebuild} | 23 ++++++++--------------
 1 file changed, 8 insertions(+), 15 deletions(-)