Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 796887 - sys-apps/portage: add QA check for ignored RUSTFLAGS (meanwhile rust packages use QA_FLAGS_IGNORED to suppress false positives)
Summary: sys-apps/portage: add QA check for ignored RUSTFLAGS (meanwhile rust packages...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: cflags ldflags
  Show dependency tree
 
Reported: 2021-06-20 13:03 UTC by Agostino Sarubbo
Modified: 2021-06-22 20:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,181.60 KB, text/plain)
2021-06-20 13:03 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-06-20 13:03:06 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-lang/starlark-rust-0.4.0 does not respect CFLAGS/LDFLAGS.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS and LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS/LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2021-06-20 13:03:08 UTC
Created attachment 716952 [details]
build.log

build log and emerge --info
Comment 2 Zac Medico gentoo-dev 2021-06-22 20:13:12 UTC
I wonder if there some way to do the equivalent of CFLAGS=-frecord-gcc-switches in RUSTFLAGS so that portage can QA check to see if your RUSTFLAGS visible in the binaries?
Comment 3 Zac Medico gentoo-dev 2021-06-22 20:19:26 UTC
> <zmedico> gyakovlev: is there some way to do the equivalent of CFLAGS=-frecord-gcc-switches in RUSTFLAGS so that portage QA check to see if your RUSTFLAGS visible in the binaries? Related bug report is this one about dev-lang/starlark-rust no respecting CFLAGS/LDFLAGS: https://bugs.gentoo.org/796887
> -*- zmedico reassigned the bug to dev-portage
> <gyakovlev> zmedico: last time I checked it was an unstable options ( gated behind -Z flag)
> <gyakovlev> so it will not work with USE=nightly
> <gyakovlev> without*
> <zmedico> aha I peaked behind -Z and there was lots of stuff there :-)
> <zmedico> can fix it in portage after it's available in stable
Comment 4 Zac Medico gentoo-dev 2021-06-22 20:27:26 UTC
Rust packages will have to use QA_FLAGS_IGNORED until we've got some kind of RUSTFLAGS support.
Comment 5 Larry the Git Cow gentoo-dev 2021-06-22 20:45:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=82ff8557c0395218bd635c2e14c71b1ce026afa0

commit 82ff8557c0395218bd635c2e14c71b1ce026afa0
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-06-22 20:36:45 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-06-22 20:45:43 +0000

    dev-lang/starlark-rust: set QA_FLAGS_IGNORED=".*" (bug 796887)
    
    Bug: https://bugs.gentoo.org/796887
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 dev-lang/starlark-rust/starlark-rust-0.4.0.ebuild | 3 +++
 1 file changed, 3 insertions(+)