Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 795045 - [guru] net-im/guilded-bin-1.0.996954 does not respect CFLAGS/LDFLAGS
Summary: [guru] net-im/guilded-bin-1.0.996954 does not respect CFLAGS/LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Bakhtiari
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2021-06-09 07:13 UTC by Agostino Sarubbo
Modified: 2021-06-15 07:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,55.86 KB, text/plain)
2021-06-09 07:13 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-06-09 07:13:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-im/guilded-bin-1.0.996954 does not respect CFLAGS/LDFLAGS.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
This machine uses GCC-11: https://gcc.gnu.org/gcc-11/porting_to.html
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS and LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0". If this is not something about c/c++ see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS/LDFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2021-06-09 07:13:05 UTC
Created attachment 714849 [details]
build.log

build log and emerge --info
Comment 2 Matthew Bakhtiari 2021-06-12 09:06:00 UTC
Looks like this isn't fixable as it receives an binary from guilded.gg itself. This is my first custom package on guru so I may be wrong
Comment 3 James Beddek 2021-06-12 10:35:43 UTC
Hi Matthew,

If you look through the build log you'll see that it complains about the following:

...
 * QA Notice: Files built without respecting CFLAGS have been detected
 *  Please include the following list of files in your report:
 * /opt/Guilded/resources/app.asar.unpacked/node_modules/iohook/builds/electron-v76-linux-x64/build/Release/uiohook.so
 * /opt/Guilded/resources/app.asar.unpacked/node_modules/iohook/builds/electron-v76-linux-x64/build/Release/iohook.node
...

This is because portage thinks these files were compiled locally rather than copied straight from the binary package. As already used in the ebuild, you can change the QA_PREBUILT variable to ".*" (everything) as nothing is compiled locally. Though I believe it's more correct to just specify the paths where the issues occur, as you seem to be doing already.

Not related to this bug I also see:

 * QA Notice: Unresolved soname dependencies:
 * 
 * 	/opt/Guilded/guilded: libasound.so.2 libcups.so.2
 * 

This can be fixed by specifying dependencies that match the libraries.
Comment 4 Larry the Git Cow gentoo-dev 2021-06-15 07:11:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=0cb5e812946c4b3a29a90e0b54b89b1aaa703e83

commit 0cb5e812946c4b3a29a90e0b54b89b1aaa703e83
Author:     Matthew Bakhtiari <dev@mtbk.me>
AuthorDate: 2021-06-13 09:12:36 +0000
Commit:     Matthew Bakhtiari <dev@mtbk.me>
CommitDate: 2021-06-13 09:12:36 +0000

    net-im/guilded-bin: fix CFLAGS & depedencies
    
    Closes: https://bugs.gentoo.org/795045
    Closes: https://bugs.gentoo.org/795042
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Matthew <dev@mtbk.me>

 net-im/guilded-bin/guilded-bin-1.0.996954.ebuild | 3 +++
 1 file changed, 3 insertions(+)