Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 794208 - sci-libs/fftw-3.3.9: two lib path issue in ARCH=riscv
Summary: sci-libs/fftw-3.3.9: two lib path issue in ARCH=riscv
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: David Seifert
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 794205
  Show dependency tree
 
Reported: 2021-06-04 22:08 UTC by Yixun Lan
Modified: 2021-06-08 02:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-sci-libs-fftw-Better-lib-handling-for-RISC-V.patch (0001-sci-libs-fftw-Better-lib-handling-for-RISC-V.patch,1.35 KB, patch)
2021-06-05 09:51 UTC, David Seifert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yixun Lan archtester gentoo-dev 2021-06-04 22:08:51 UTC
1) error here
/var/tmp/portage/sci-libs/fftw-3.3.9/temp/environment: line 2354: /var/tmp/portage/sci-libs/fftw-3.3.9/image/usr/lib*/pkgconfig/*_omp.pc: No such file or directory
 * ERROR: sci-libs/fftw-3.3.9::gentoo failed (install phase):

2) root cause
due to we follow two lib path in RISC-V, also see bug #794205

3) possible fix
+++ b/sci-libs/fftw/fftw-3.3.9.ebuild
@@ -148,7 +148,7 @@ src_install() {
        fi
 
        local x
-       for x in "${ED}"/usr/lib*/pkgconfig/*.pc; do
+       for x in "${ED}"/usr/$(get_libdir)/pkgconfig/*.pc; do
                local u
                for u in $(usev mpi) $(usev threads) $(usex openmp omp ""); do
                        sed -e "s|-lfftw3[flq]\?|&_${u} &|" "$x" > "${x%.pc}_${u}.pc" || die


Reproducible: Always
Comment 1 Yixun Lan archtester gentoo-dev 2021-06-04 22:12:21 UTC
hey, one question here, I'm not sure if this patch will break multilib profile?
Comment 2 David Seifert gentoo-dev 2021-06-05 08:59:57 UTC
(In reply to Yixun Lan from comment #1)
> hey, one question here, I'm not sure if this patch will break multilib
> profile?

At a quick glance, it does
Comment 3 David Seifert gentoo-dev 2021-06-05 09:51:47 UTC
Created attachment 713793 [details, diff]
0001-sci-libs-fftw-Better-lib-handling-for-RISC-V.patch

Please test this patch
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2021-06-05 11:07:11 UTC
(In reply to Yixun Lan from comment #1)
> hey, one question here, I'm not sure if this patch will break multilib
> profile?

No it won't, because outside the toolchain now only one profile the main one is ever built. What we retain as "multilib" internally only affects gcc/glibc/binutils.

So your fix is fine, and you can even drop the for statement because there is only one path.

No multilib* eclasses here please.
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2021-06-05 11:11:22 UTC
(In reply to Andreas K. Hüttel from comment #4)
> (In reply to Yixun Lan from comment #1)
> > hey, one question here, I'm not sure if this patch will break multilib
> > profile?
> 
> No it won't, because outside the toolchain now only one profile the main one
> is ever built. What we retain as "multilib" internally only affects
> gcc/glibc/binutils.
> 
> So your fix is fine, and you can even drop the for statement because there
> is only one path.
> 
> No multilib* eclasses here please.

Scratch that. I need to wake up first. RISC-V doesnt need the patch, but e.g. amd64 does.

So yes, David's solution is correct.
Comment 6 Larry the Git Cow gentoo-dev 2021-06-08 02:29:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bccd13e128ae7138f84d61f408f4f734e32a3c67

commit bccd13e128ae7138f84d61f408f4f734e32a3c67
Author:     Yixun Lan <dlan@gentoo.org>
AuthorDate: 2021-06-08 01:34:50 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2021-06-08 02:22:55 +0000

    sci-libs/fftw: fix two lib path issue for ARCH=riscv
    
    thanks @soap for helping this
    
    Closes: https://bugs.gentoo.org/794208
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 sci-libs/fftw/fftw-3.3.9.ebuild | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)