Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 792843 - [salfter] Ebuild failures occuring in global scope
Summary: [salfter] Ebuild failures occuring in global scope
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Scott Alfter
URL: https://qa-reports.gentoo.org/output/...
Whiteboard:
Keywords:
Depends on:
Blocks: repository-qa-issues
  Show dependency tree
 
Reported: 2021-05-29 15:17 UTC by Michał Górny
Modified: 2022-05-24 19:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-05-29 15:17:24 UTC
Our automated repository checks [1] have detected that the 'salfter'
repository contains ebuilds that trigger fatal errors during the cache
regeneration. This usually means that the ebuilds call 'die' in global
scope indicating serious issues or have other serious QA violations.

Global-scope failures prevent the ebuild not only from being installed
but also from being properly processed by the Package Manager. Since
metadata can not be obtained for those ebuilds, no cache entries are
created for them and the Package Manager needs to retry running them
every time it stumbles upon them. This involves both a serious slowdown
and repeating error output while performing dependency resolution.

The most common cause of global-scope failures is use of removed or
banned APIs in old ebuilds. In particular, this includes eclasses being
removed or removing support for old EAPIs. Nonetheless there are also
other issues such as performing illegal operations in global scope
(external program calls), malformed bash in ebuilds or malformed
metadata.xml.

The error log for the repository can be found at:

  https://qa-reports.gentoo.org/output/repos/salfter.html

In particular, please look for highlighted error messages.

Please fix the issue ASAP, possibly via removing unmaintained, old
ebuilds. We reserve the right to remove the repository from our list if
we do not receive any reply within 4 weeks.

[1]:https://wiki.gentoo.org/wiki/Project:Repository_mirror_and_CI
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-10 06:30:43 UTC
ping
Comment 2 Thomas Bracht Laumann Jespersen 2022-04-01 07:59:31 UTC
ping.
Comment 3 Larry the Git Cow gentoo-dev 2022-04-14 07:35:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=31746197a97eb70829afb75db3dcd19d37448ae4

commit 31746197a97eb70829afb75db3dcd19d37448ae4
Author:     Thomas Bracht Laumann Jespersen <t@laumann.xyz>
AuthorDate: 2022-04-13 15:51:57 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-04-14 07:26:07 +0000

    repositories.xml: remove 'salfter' overlay
    
    Longstanding CI failures, repository appears to be maintained, but the
    failures haven't been addressed.
    
    Bug: https://bugs.gentoo.org/792843
    Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
    Closes: https://github.com/gentoo/api-gentoo-org/pull/507
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 files/overlays/repositories.xml | 10 ----------
 1 file changed, 10 deletions(-)
Comment 4 Scott Alfter 2022-04-14 17:22:04 UTC
This morning was the first I'd heard of any issues...don't know how that happened, and the error log mentioned in the first message is no longer accessible.

With a little bit of poking around, though, it appears that the errors may have had to do with some ebuilds still using EAPI 4 or 5.  I found them all, deleted most as I no longer needed them, and the relative handful that I wanted to keep have been updated to EAPI 8.  The most recent commit (e5cc352b) fixed the last of the old ebuilds to bring it up to EAPI 8.  How do I get my overlay reinstated?
Comment 5 Thomas Bracht Laumann Jespersen 2022-04-14 18:37:20 UTC
(In reply to Scott Alfter from comment #4)
> This morning was the first I'd heard of any issues...don't know how that
> happened, and the error log mentioned in the first message is no longer
> accessible.

Sorry that you've missed them!
 
> With a little bit of poking around, though, it appears that the errors may
> have had to do with some ebuilds still using EAPI 4 or 5.  I found them all,
> deleted most as I no longer needed them, and the relative handful that I
> wanted to keep have been updated to EAPI 8.  The most recent commit
> (e5cc352b) fixed the last of the old ebuilds to bring it up to EAPI 8.  How
> do I get my overlay reinstated?

I think the simplest thing is just to open a PR against [1] that effectively reverts [2].

[1]: https://github.com/gentoo/api-gentoo-org
[2]: https://github.com/gentoo/api-gentoo-org/pull/507
Comment 6 Scott Alfter 2022-04-14 18:50:23 UTC
(In reply to Thomas Bracht Laumann Jespersen from comment #5)
> (In reply to Scott Alfter from comment #4)
> > How do I get my overlay reinstated?
> 
> I think the simplest thing is just to open a PR against [1] that effectively
> reverts [2].

Got it...it's already in the works.
Comment 7 Larry the Git Cow gentoo-dev 2022-04-18 19:22:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=85bf6a2cb30ac659fa0655af2fae0a093df0f771

commit 85bf6a2cb30ac659fa0655af2fae0a093df0f771
Author:     Scott Alfter <scott@alfter.us>
AuthorDate: 2022-04-18 14:26:52 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-04-18 19:06:53 +0000

    Revert "repositories.xml: remove 'salfter' overlay"
    
    This reverts commit 31746197a97eb70829afb75db3dcd19d37448ae4.
    
    EAPI 4/5 ebuilds either updated or removed.
    
    Bug: https://bugs.gentoo.org/792843
    Signed-off-by: Scott Alfter <scott@alfter.us>
    Closes: https://github.com/gentoo/api-gentoo-org/pull/510
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 files/overlays/repositories.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 8 Thomas Bracht Laumann Jespersen 2022-04-29 11:37:38 UTC
Reopening. The QA reports mention EAPI 0, 2 and 4, also some PYTHON_COMPAT:

    https://qa-reports.gentoo.org/output/repos/salfter.html
Comment 9 Thomas Bracht Laumann Jespersen 2022-05-23 12:30:12 UTC
ping
Comment 10 Scott Alfter 2022-05-23 19:09:53 UTC
The remaining issues should be fixed as of the most recent commit:

https://gitlab.com/salfter/portage/-/commit/4f24250466db32a2a388d663bc03dc3cb0477b06
Comment 11 Thomas Bracht Laumann Jespersen 2022-05-24 19:30:55 UTC
The bug seems to be fixed in the repository. Closing.
Comment 12 Thomas Bracht Laumann Jespersen 2022-05-24 19:31:24 UTC
Thanks!