Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 792804 - dev-qt/qtcore-5.15.2-r2 - configure: line 799: make LIBTOOL=rdlibtool: command not found
Summary: dev-qt/qtcore-5.15.2-r2 - configure: line 799: make LIBTOOL=rdlibtool: comman...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-05-29 11:56 UTC by Toralf Förster
Modified: 2022-07-23 11:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.64 KB, text/plain)
2021-05-29 11:56 UTC, Toralf Förster
Details
dev-qt:qtcore-5.15.2-r2:20210529-111925.log (dev-qt:qtcore-5.15.2-r2:20210529-111925.log,4.28 KB, text/plain)
2021-05-29 11:56 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,84.44 KB, text/plain)
2021-05-29 11:56 UTC, Toralf Förster
Details
environment (environment,117.20 KB, text/plain)
2021-05-29 11:56 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,19.19 KB, application/x-bzip)
2021-05-29 11:56 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,5.38 KB, application/x-bzip)
2021-05-29 11:56 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,28.68 KB, application/x-bzip)
2021-05-29 11:56 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-05-29 11:56:05 UTC
/var/tmp/portage/dev-qt/qtcore-5.15.2-r2/work/qtbase-everywhere-src-5.15.2/configure: line 799: make LIBTOOL=rdlibtool: command not found
 * ERROR: dev-qt/qtcore-5.15.2-r2::gentoo failed (configure phase):
 *   configure failed
 * 
 * Call stack:
 *     ebuild.sh, line  127:  Called src_configure
 *   environment, line 2826:  Called qt5-build_src_configure

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_hardened-j3-20210528-173809

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11.1.0 *
/usr/lib/llvm/10
10.0.1
Python 3.8.10
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.52.1 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.292_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sat May 29 10:50:11 UTC 2021

emerge -qpvO dev-qt/qtcore
[ebuild  N    ] dev-qt/qtcore-5.15.2-r2  USE="-debug -icu -old-kernel -systemd -test"
Comment 1 Toralf Förster gentoo-dev 2021-05-29 11:56:06 UTC
Created attachment 712182 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-05-29 11:56:07 UTC
Created attachment 712185 [details]
dev-qt:qtcore-5.15.2-r2:20210529-111925.log
Comment 3 Toralf Förster gentoo-dev 2021-05-29 11:56:09 UTC
Created attachment 712188 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2021-05-29 11:56:10 UTC
Created attachment 712191 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2021-05-29 11:56:11 UTC
Created attachment 712194 [details]
etc.portage.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2021-05-29 11:56:13 UTC
Created attachment 712197 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-05-29 11:56:14 UTC
Created attachment 712200 [details]
temp.tar.bz2
Comment 8 Toralf Förster gentoo-dev 2021-06-21 14:20:44 UTC
ok, related to IRC:

[4:17:48 pm] <+sam_> are you setting MAKE="make libtool="?
[4:17:57 pm] <+toralf> yes : https://github.com/toralf/tinderbox/blob/master/bin/setup_img.sh#L331
[4:18:12 pm] <+sam_> don't do that I think
[4:18:16 pm] <+toralf> got that from a wiki page 
[4:18:17 pm] <+sam_> just the other two
[4:18:33 pm] <+toralf> ok, removed
[4:18:40 pm] <+sam_> https://wiki.gentoo.org/wiki/Slibtool#Usage this mentions it indeed
[4:18:45 pm] <+sam_> but drop it for now i think


I can mark this as invalid ?
Comment 9 Davide Pesavento gentoo-dev 2021-06-21 20:57:16 UTC
Not sure. The "problem" is that $MAKE is quoted in the configure...

       	(cd "$outpath/qmake"; "$MAKE") || exit 2

probably to guard against someone setting MAKE="<path with spaces>". So the shell tries to execute "make LIBTOOL=rdlibtool" as if it was the name of a command, which obviously doesn't exist. I don't think it's expected to have options/variables in the value of $MAKE (that's what MAKEFLAGS is for), but please correct me if I'm wrong.

Note however that we patch that line to include MAKEOPTS and EXTRA_EMAKE, as customary in gentoo. So, why don't you use EXTRA_EMAKE="LIBTOOL=rdlibtool" and leave MAKE alone?
Comment 10 orbea 2022-07-15 21:27:11 UTC
Generally slibtool is set with:

  MAKEFLAGS='LIBTOOL=rlibtool'

But some build systems use recursive make where the MAKEFLAGS env gets lost and this is where setting MAKE is required:

  MAKE='make LIBTOOL=libtool'

Adding arguments to the make(1) command is not quite the same thing, the MAKE variable is used by the build system itself.

The issue here is quoting "$MAKE" and the fix would be to remove the quotes.
Comment 11 Andreas Sturmlechner gentoo-dev 2022-07-16 14:28:52 UTC
Aren't you really saying that we should patch configure to add MAKEFLAGS as well?
Comment 12 Andreas Sturmlechner gentoo-dev 2022-07-16 14:36:12 UTC
Ah I see. I suppose it shouldn't hurt to drop the quoting for our usage...
Comment 13 Larry the Git Cow gentoo-dev 2022-07-23 11:22:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4859473944244496cbd0b28f5fb525a4a930e4b

commit c4859473944244496cbd0b28f5fb525a4a930e4b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-07-17 15:57:54 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-07-23 11:21:01 +0000

    dev-qt/qtcore: Fix configure w/ slibtool
    
    Closes: https://bugs.gentoo.org/792804
    Package-Manager: Portage-3.0.32, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtcore/files/qtcore-5.15.5-slibtool.patch | 29 ++++++++++++++++++++++++
 dev-qt/qtcore/qtcore-5.15.5-r2.ebuild            |  2 ++
 2 files changed, 31 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3834431f616e7cd362315b23ea47e2aade67a264

commit 3834431f616e7cd362315b23ea47e2aade67a264
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-07-17 15:39:40 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-07-23 11:21:01 +0000

    qt5-build.eclass: Support sed regardless if $MAKE is quoted or not
    
    Bug: https://bugs.gentoo.org/792804
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/qt5-build.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 Larry the Git Cow gentoo-dev 2022-07-23 11:24:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=aa7f8e5bd7efbba10385ac768a817f0675daded1

commit aa7f8e5bd7efbba10385ac768a817f0675daded1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-07-17 15:39:40 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-07-23 11:23:35 +0000

    qt5-build.eclass: Support sed regardless if $MAKE is quoted or not
    
    Bug: https://bugs.gentoo.org/792804
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/qt5-build.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)