Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 788082 - gui-libs/gtk-4.2.1: Install fails because of outdated mv command in install
Summary: gui-libs/gtk-4.2.1: Install fails because of outdated mv command in install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
: 788160 788166 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-04 06:27 UTC by Bernd Feige
Modified: 2021-05-05 08:15 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix.patch (0001-gui-libs-gtk-fix-doc-issues.patch,2.12 KB, patch)
2021-05-04 15:53 UTC, David Michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2021-05-04 06:27:16 UTC
The ebuild contains:
src_install() {
    meson_src_install
    mv "${ED}"/usr/share/doc/{gtk4,${P}} || die
}

This leads to the install error "mv: cannot stat '/var/tmp/portage/gui-libs/gtk-4.2.1/image/usr/share/doc/gtk4': No such file or directory"

The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4.

Reproducible: Always
Comment 1 Matt Turner gentoo-dev 2021-05-04 14:30:59 UTC
> The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4.

Can you show me where that happened? I looked in git and didn't see it.
Comment 2 Furude Rika 2021-05-04 15:08:12 UTC
(In reply to Matt Turner from comment #1)
> > The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4.
> 
> Can you show me where that happened? I looked in git and didn't see it.

Is this commit that you probably have missed? 
https://gitlab.gnome.org/GNOME/gtk/-/commit/642f32e14d507df5282197afc78efb6405cfe9c2#33e3f16a2e94c672e89c47874c4eb2dcd70f1bf1)
Comment 3 Furude Rika 2021-05-04 15:10:44 UTC
Same problem appears on gui-libs/gtk-4.2.0, too.
Comment 4 Bernd Feige 2021-05-04 15:32:45 UTC
(In reply to myloveyuxuan from comment #2)
> (In reply to Matt Turner from comment #1)
> > > The whole src_install() function can be removed because the build was fixed upstream to install to /usr/share/doc/gtk-4.2.1/ instead of gtk4.
> > 
> > Can you show me where that happened? I looked in git and didn't see it.
> 
> Is this commit that you probably have missed? 
> https://gitlab.gnome.org/GNOME/gtk/-/commit/
> 642f32e14d507df5282197afc78efb6405cfe9c2#33e3f16a2e94c672e89c47874c4eb2dcd70f
> 1bf1)

Sorry, I don't think so as this occurs with -gtk-doc - /usr/share/doc/gtk-4.2.1 is, as far as I can see, simply the default created by einstalldocs (/usr/portage/eclass/eutils.eclass). Something was previously installed under "/usr/share/doc/gtk4" that needed to be patched up but not any longer. Could it be related to the recent app-portage/portage-utils-0.91 upgrade?
Comment 5 Ionen Wolkens gentoo-dev 2021-05-04 15:35:23 UTC
*** Bug 788160 has been marked as a duplicate of this bug. ***
Comment 6 David Michael 2021-05-04 15:53:29 UTC
Created attachment 705996 [details, diff]
fix.patch

This fixed it for me.
Comment 7 Brian Evans (RETIRED) gentoo-dev 2021-05-04 16:02:44 UTC
*** Bug 788166 has been marked as a duplicate of this bug. ***
Comment 8 Chris Mayo 2021-05-04 18:46:33 UTC
Three other directories are being installed:

  /usr/share/doc/gdk4
  /usr/share/doc/gdk4-wayland
  /usr/share/doc/gsk4

Also ${PF} instead of ${P}.
My preference would be as per econf --htmldir

/usr/share/doc/${PF}/html/
                          gdk4
                          gdk4-wayland
                          gsk4
                          gtk4

Automatically excluded from docompress (which looks relevant for the bundled fonts logo and search index) etc.
Comment 9 Chris Mayo 2021-05-04 19:27:57 UTC
Suggest, instead of src_install():

src_prepare() {
	default
	sed -i "s:gtk_datadir / 'doc':gtk_datadir / 'doc/${PF}/html':" docs/reference/meson.build || die
}
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-04 19:29:49 UTC
I think Matt is on it.
Comment 11 Larry the Git Cow gentoo-dev 2021-05-04 20:12:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=29744120a6b62882342edc5400bf8b17600e52ed

commit 29744120a6b62882342edc5400bf8b17600e52ed
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2021-05-04 14:35:53 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2021-05-04 20:12:16 +0000

    gui-libs/gtk: Install docs to html/
    
    Suggested by Chris Mayo to avoid compressing included SVGs and fonts.
    Thanks for David Michael for the initial patch.
    
    Closes: https://bugs.gentoo.org/788082
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 gui-libs/gtk/gtk-4.2.1.ebuild | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)