Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 784092 - app-text/zathura-9999: error: implicit declaration of function 'girara_command_run' [-Werror=implicit-function-declaration]
Summary: app-text/zathura-9999: error: implicit declaration of function 'girara_comman...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2021-04-19 10:51 UTC by Joonas Niilola
Modified: 2023-01-08 16:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (zathura-9999:20210419-103731.log,44.38 KB, text/x-log)
2021-04-19 10:51 UTC, Joonas Niilola
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2021-04-19 10:51:51 UTC
Created attachment 700734 [details]
build.log

build.log as attachment.
Comment 1 Piotr Karbowski (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-04-19 11:07:22 UTC
I believe you should report it upstream, I cannot really imagine supporting live builds in terms of such errors.
Comment 2 Joonas Niilola gentoo-dev 2021-04-19 11:20:14 UTC
This was hit by a tinderbox run, I have no personal attachment to this project. 

What do you think about removing -9999 ebuild if you cba to maintain it?
Comment 3 Joonas Niilola gentoo-dev 2021-04-19 11:42:16 UTC
Let me clarify to not sound that rude (it was not my intention):

Usually upstream keeps flags like these on during development cycles, and I have no clue what's causing the issue as I'm not invested in upstream. But the fix to get this compiled on Gentoo is easy, just strip / patch out any -Werror flags.

  https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#-werror-compiler-flag-not-removed
Comment 4 Piotr Karbowski (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2021-04-19 11:45:52 UTC
(In reply to Joonas Niilola from comment #2)
> What do you think about removing -9999 ebuild if you cba to maintain it?

It has it's purposes, running it via tinderbox when it's intentionally not even keyworded is not one of them. I do not want to remove it just because you hit a build failure there
Comment 5 Piotr Karbowski (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2023-01-08 16:02:42 UTC
Looked more into it. The girara_command_run was not present in girara 0.3.5 that your bug report seems to be using, I see single mention of it in your log

    Run-time dependency girara-gtk3 found: YES 0.3.5

In the current girara 0.3.7 it is declared in girara/commands.h header as bool and the header is in fact included, in 0.3.5 it was there, but did not had girara_commands_run at all. The ebuilds already has >=0.3.7 dependency on girara so I believe this is addressed now.

Related commit

    commit c44b3e68c1990b0ed81c22bfe752526fecada187
    Author: Piotr Karbowski <slashbeast@gentoo.org>
    Date:   2023-01-08 16:28:02 +0100

    app-text/zathura: 0.5.2-r1, 9999: add subslot.
    
    The plugins needs to be rebuilt after zathura updates in order to work.
    
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

The commit syncs 9999 and 0.5.2-r1 ebuilds ensuring dependencies parity bumping girara on 9999 ebuild to >=0.3.7.

I still would like to challenge the feasibility of reporting issues of this kind in live ebuilds. Here we had a new zathura code that was depending on new girara dependency, while I bumped it in tree on 2022-03-28, your report from 2021-04-19 seems to be using the old version 0.3.5, I do not think it is reasonable to expect 9999 ebuilds to have always up to date deps as soon as upstream changes the development branch, if it had, it would pull the 0.3.7 update on your testing system and we wouldn't have this bug. 

If you still insist on going with 9999 testing and reports, please make sure that you provide some more information, like dump of installed packages, and if possible, try to update your @world to latest and re-trying 9999 ebuild before filling a report. Thanks.
Comment 6 Piotr Karbowski (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2023-01-08 16:05:13 UTC
Sorry, I did it again, mixed the dates, 2021 != 2022, of course you couldn't had the latest girara that was added year after your report. Though I stand strong with rest of the comment re 9999 testing. It failed because there was no compatible girara in tree.