Created attachment 699720 [details, diff] updated patch app-text/poppler fails to build with Clang for me when the patch poppler-20.12.0-respect-cflags.patch is applied (undefined symbols). I narrowed this down to the patch removing the following: if(CMAKE_COMPILER_IS_GNUCXX) poppler_check_link_flag("-Wl,--as-needed" GCC_HAS_AS_NEEDED) if(GCC_HAS_AS_NEEDED) set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--as-needed") set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,--as-needed") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--as-needed") endif(GCC_HAS_AS_NEEDED) endif (CMAKE_COMPILER_IS_GNUCXX) Clang does not support the -Wlogical-op flag which is also passed through due to the same patch. Updated patch attached which removes -Wlogical-op and restores adding -Wl,--as-needed
Created attachment 699723 [details] build.log
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fd92e2a9596191195ebd06d964e164a88a2f21a commit 0fd92e2a9596191195ebd06d964e164a88a2f21a Author: Theo Anderson <telans@posteo.de> AuthorDate: 2021-04-13 22:24:42 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2021-04-21 13:10:35 +0000 app-text/poppler: update respect-cflags patch fix building on clang by restoring additions of -Wl,--as-needed Closes: https://bugs.gentoo.org/782721 Signed-off-by: Theo Anderson <telans@posteo.de> Closes: https://github.com/gentoo/gentoo/pull/20370 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> ....patch => poppler-21.04.0-respect-cflags.patch} | 45 +++++++++++++--------- app-text/poppler/poppler-21.02.0.ebuild | 2 +- app-text/poppler/poppler-21.03.0.ebuild | 2 +- app-text/poppler/poppler-21.04.0.ebuild | 2 +- app-text/poppler/poppler-9999.ebuild | 2 +- 5 files changed, 31 insertions(+), 22 deletions(-)
