Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 781236 - dev-qt/qtwebengine fails to build with =dev-libs/icu-69.1
Summary: dev-qt/qtwebengine fails to build with =dev-libs/icu-69.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
: 791247 (view as bug list)
Depends on:
Blocks: icu-69.1
  Show dependency tree
 
Reported: 2021-04-08 19:41 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2021-05-21 13:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,102.04 KB, application/x-xz)
2021-04-08 19:41 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details
qtwebengine-5.15.2_p20210419-icu69.patch (qtwebengine-5.15.2_p20210419-icu69.patch,3.22 KB, patch)
2021-04-20 16:19 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-04-08 19:41:24 UTC
Created attachment 698679 [details]
build.log.xz

In file included from gen/v8/v8_base_without_compiler_jumbo_31.cc:7:
./../../../../qtwebengine-5.15.2_p20210406/src/3rdparty/chromium/v8/src/objects/js-list-format.cc: In static member function ‘static v8::internal::MaybeHandle<v8::internal::JSListFormat> v8::internal::JSListFormat::New(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>)’:
./../../../../qtwebengine-5.15.2_p20210406/src/3rdparty/chromium/v8/src/objects/js-list-format.cc:146:67: error: ‘static icu::ListFormatter* icu::ListFormatter::createInstance(const icu::Locale&, const char*, UErrorCode&)’ is private within this context
  146 |       icu_locale, GetIcuStyleString(style_enum, type_enum), status);
      |                                                                   ^
In file included from ./../../../../qtwebengine-5.15.2_p20210406/src/3rdparty/chromium/v8/src/objects/js-list-format.cc:25,
                 from gen/v8/v8_base_without_compiler_jumbo_31.cc:7:
/usr/include/unicode/listformatter.h:267:27: note: declared private here
  267 |     static ListFormatter* createInstance(const Locale& locale, const char* style, UErrorCode& errorCode);
      |                           ^~~~~~~~~~~~~~


sultan found a working fix at:

  https://chromium-review.googlesource.com/c/v8/v8/+/2477751
Comment 1 Andreas Sturmlechner gentoo-dev 2021-04-20 16:19:16 UTC
Created attachment 701247 [details, diff]
qtwebengine-5.15.2_p20210419-icu69.patch

Patch tested successfully but against a snapshot version that I don't want to push to the ebuild repository yet.

Attaching it anyway just in case anyone else wants to build current ~arch version wiht it applied.
Comment 2 Larry the Git Cow gentoo-dev 2021-04-20 22:23:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3fa77f8de69294f0a17d592d1d6e2985d2b561b

commit e3fa77f8de69294f0a17d592d1d6e2985d2b561b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-04-20 22:19:24 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-04-20 22:22:40 +0000

    dev-qt/qtwebengine: Fix build with ICU-69.1
    
    Tested-by: Jimi Huotari <chiitoo@gentoo.org>
    Closes: https://bugs.gentoo.org/781236
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/qtwebengine-5.15.2_p20210406-icu69.patch | 92 ++++++++++++++++++++++
 .../qtwebengine-5.15.2_p20210406.ebuild            |  1 +
 2 files changed, 93 insertions(+)
Comment 3 Andreas Sturmlechner gentoo-dev 2021-05-21 13:53:28 UTC
*** Bug 791247 has been marked as a duplicate of this bug. ***