Bug 780888 – media-sound/mixxx-{2.3.9999,9999} docs installation changed, mixxx-9999-docs.patch fails to apply

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description jospezial 2021-04-07 18:56:55 UTC]

https://github.com/mixxxdj/mixxx/pull/3754/files

Should we remove the patch and install Mixxx-Manual.pdf Mixxx-Keyboard-Shortcuts.pdf the Mixxx way or change the patch?

I am not sure about these lines:
https://github.com/mixxxdj/mixxx/blob/48927dbd9586f7923c987fe90f7f20e6b1887291/CMakeLists.txt#L2714-L2716

[Comment 1 jospezial 2021-04-10 06:22:59 UTC]

If I remove the docs stuff from the ebuild then the files are installed by cmake:
equery f mixxx|grep doc
/usr/share/doc
/usr/share/doc/mixxx-2.3.9999
/usr/share/doc/mixxx-2.3.9999/COPYING.bz2
/usr/share/doc/mixxx-2.3.9999/LICENSE.bz2
/usr/share/doc/mixxx-2.3.9999/Mixxx-Keyboard-Shortcuts.pdf
/usr/share/doc/mixxx-2.3.9999/Mixxx-Manual.pdf
/usr/share/doc/mixxx-2.3.9999/README.bz2
/usr/share/doc/mixxx-2.3.9999/README.md.bz2

But when I open these from Mixxx help menu, then the online version is opened in my browser.

[Comment 2 Miroslav Šulc 2021-06-30 11:17:14 UTC]

then i suppose the docs path must be somewhere hardcoded in mixxx. any progress on tions?

[Comment 3 Miroslav Šulc 2021-06-30 11:17:35 UTC]

i mean "any progress on this?" :-)

[Comment 4 jospezial 2021-06-30 19:58:57 UTC]

(In reply to Miroslav Šulc from comment #2)
> then i suppose the docs path must be somewhere hardcoded in mixxx. any
> progress on this?

CMakeLists.txt has for the docs:
set(MIXXX_INSTALL_DOCDIR "${CMAKE_INSTALL_DOCDIR}")

DESTINATION
      "${MIXXX_INSTALL_DOCDIR}"

src/widget/wmainmenubar.cpp uses the pdf files but I don't understands where it looks for the files and then downloads the online versions.

[Comment 5 jospezial 2023-01-23 07:11:55 UTC]

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a3a03453658305cf00633b5b241b61d4fefd29e
"media-sound/mixxx: fix(disable) doc generation"

I need to test that before closing.

[Comment 6 jospezial 2023-06-03 08:21:34 UTC]

Closing because the main reason for this bug is fixed. (The patch has been updated.)