Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 780741 - net-misc/remmina-1.4.13 makes wayland mandatory
Summary: net-misc/remmina-1.4.13 makes wayland mandatory
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben Kohler
URL: https://gitlab.com/Remmina/Remmina/-/...
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2021-04-07 07:14 UTC by Attila Tóth
Modified: 2021-07-10 07:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
remmina-1.4.13-r2.ebuild (remmina-1.4.13-r2.ebuild,2.61 KB, text/plain)
2021-04-07 07:20 UTC, Attila Tóth
Details
remmina-1.4.13-wayland-non-mandatory.patch (remmina-1.4.13-wayland-non-mandatory.patch,1.77 KB, patch)
2021-04-07 07:21 UTC, Attila Tóth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Tóth 2021-04-07 07:14:48 UTC
Upstreams remmina-1.4.13 introduced wayland as a mandatory component, but only forces wayland in configure.
Recent ebuild followed these changes. Related bug:
https://bugs.gentoo.org/779436

Reproducible: Always
Comment 1 Attila Tóth 2021-04-07 07:20:50 UTC
Created attachment 698160 [details]
remmina-1.4.13-r2.ebuild

Proposed remmina ebuild makes wayland optional introducing it as a use flag.
Comment 2 Attila Tóth 2021-04-07 07:21:55 UTC
Created attachment 698163 [details, diff]
remmina-1.4.13-wayland-non-mandatory.patch

Proposed patch used by the ebuild.
Comment 3 Ben Kohler gentoo-dev 2021-05-10 14:17:52 UTC
I see this patch was applied upstream, but... is it an automagic dep now or is it able to be forcibly enabled/disabled with a -D option?
Comment 4 Ben Kohler gentoo-dev 2021-07-09 13:14:07 UTC
It's looking to me like the build system now checks for wayland but doesn't care if it's there or not, and doesn't actually use it at build time in either case.

Can you confirm that?
Comment 5 Larry the Git Cow gentoo-dev 2021-07-09 14:34:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdf88b261c1bae48e44418dbf72936161f5c8650

commit cdf88b261c1bae48e44418dbf72936161f5c8650
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2021-07-09 14:33:29 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2021-07-09 14:33:59 +0000

    net-misc/remmina: remove (seemingly) unneeded wayland dep
    
    Remmina checks for wayland during configure but doesn't seem to care
    whether it's present or not, and the binaries do not link to wayland in
    either case.
    
    Bug: https://bugs.gentoo.org/780741
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-misc/remmina/remmina-1.4.20.ebuild | 1 -
 1 file changed, 1 deletion(-)
Comment 6 Attila Tóth 2021-07-10 07:41:13 UTC
(In reply to Ben Kohler from comment #4)
> It's looking to me like the build system now checks for wayland but doesn't
> care if it's there or not, and doesn't actually use it at build time in
> either case.
> 
> Can you confirm that?

I'm maintaining my own version, that doesn't require wayland as a mandatory dependency, but only if the USE flag is set.