Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 778797 - dev-libs/libdnet-1.16.4 fails tests
Summary: dev-libs/libdnet-1.16.4 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 913838
  Show dependency tree
 
Reported: 2021-03-27 22:29 UTC by Jonathan Lovelace
Modified: 2024-03-23 18:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-libs:libdnet-1.14-r2:20210327-174428.log (dev-libs:libdnet-1.14-r2:20210327-174428.log,109.73 KB, text/x-log)
2021-03-27 22:29 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,8.14 KB, text/plain)
2021-03-27 22:29 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2021-03-27 22:29:35 UTC
Created attachment 695193 [details]
dev-libs:libdnet-1.14-r2:20210327-174428.log

=dev-libs/libdnet-1.14-r2 fails three of its tests: check_addr, check_ip, and check_fw. Here's the contents of the test-suite.log referenced in the build log, minus the summary header:

FAIL: check_addr
================

Running suite(s): addr
92%: Checks: 13, Failures: 1, Errors: 0
check_addr.c:194:F:core:test_addr_pton:0: accepted triple octet
FAIL check_addr (exit status: 1)

FAIL: check_fw
==============

Running suite(s): fw
80%: Checks: 5, Failures: 1, Errors: 0
check_fw.c:21:F:core:test_fw_openclose:0: open failed
FAIL check_fw (exit status: 1)

FAIL: check_ip
==============

Running suite(s): ip
85%: Checks: 7, Failures: 1, Errors: 0
check_ip.c:21:F:core:test_ip_openclose:0: open failed
FAIL check_ip (exit status: 1)
Comment 1 Jonathan Lovelace 2021-03-27 22:29:53 UTC
Created attachment 695196 [details]
emerge-info.txt
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-11 07:13:01 UTC
tinderbox_musl has reproduced this issue with version 1.16.1 - Updating summary.
Comment 3 Rick Farina (Zero_Chaos) gentoo-dev 2024-01-09 20:56:00 UTC
reproduced this issue on 1.16.4 on amd64 with glibc

PASS: check_addr
PASS: check_arp
PASS: check_blob
PASS: check_eth
FAIL: check_fw
FAIL: check_ip
PASS: check_intf
PASS: check_rand
PASS: check_route
============================================================================
Testsuite summary for libdnet 1.16.4
============================================================================
# TOTAL: 9
# PASS:  7
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See test/check/test-suite.log
============================================================================
Comment 4 matoro archtester 2024-01-09 22:26:41 UTC
Debian has an explanation for why these are OK to fail here:

https://salsa.debian.org/debian/libdumbnet/-/blob/master/debian/rules?ref_type=heads

	# Running test suite. Errors are being ignored because several tests
	# are bound to fail:
	# * check_addr: fails because glibc gethostbyname() accepts malformed
	#   IPs
	# * check_ip: fails because test includes binding to a RAW socket
	#   which requires CAP_NET_ADMIN
	# * check_fw: fails because Linux doesn't provide a simple userspace
	#   fw API (and libdumbnet therefore includes its fw-none module which
	#   just returns ENOSYS)

check_addr seems to be fixed, but the other two are legit.  We should just kill these two tests then, since one requires elevated privs and the other is an XFAIL on Linux.
Comment 5 Larry the Git Cow gentoo-dev 2024-03-23 18:11:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70ec3ac4c1b52d29c86004c74ddabbefa919866a

commit 70ec3ac4c1b52d29c86004c74ddabbefa919866a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-23 18:11:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-23 18:11:06 +0000

    dev-libs/libdnet: fix tests
    
    XFAIL 2 known-bad tests, using Debian's rationale (they also only fail
    in our sandboxes IIRC). Thanks to matoro for the hint.
    
    Closes: https://bugs.gentoo.org/778797
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libdnet/libdnet-1.16.4.ebuild |  8 +++++++-
 dev-libs/libdnet/libdnet-1.17.0.ebuild | 11 ++++++++---
 dev-libs/libdnet/libdnet-1.18.0.ebuild |  9 +++++++--
 3 files changed, 22 insertions(+), 6 deletions(-)