trying to compile git-2.31.0 breaks with Makefile:1369: *** The USE_LIBPCRE1 build option has been removed, use version 2 with USE_LIBPCRE. Stop. Reproducible: Always Actual Results: compile breaks Expected Results: git compiles with an error [ebuild U ~] dev-vcs/git-2.31.0::gentoo [2.30.2::gentoo] USE="blksha1 curl gpg iconv nls pcre perl threads webdav -cgi -cvs -doc -emacs -gnome-keyring -highlight (-libressl) -mediawiki -mediawiki-experimental (-pcre-jit) -perforce (-ppcsha1) -subversion -test -tk -xinetd" PYTHON_SINGLE_TARGET="python3_8 -python3_7 -python3_9" 0 KiB
Same here. Bugzilla gives me an internal server error when I try to attach a build.log, but it's short enough that I pasted it below. dev-vcs/git-2.30.2::gentoo was built with the following: USE="blksha1 -cgi curl cvs -doc emacs -gnome-keyring gpg -highlight iconv (-libressl) -mediawiki -mediawiki-experimental nls pcre (-pcre-jit) -perforce perl (-ppcsha1) -subversion -test threads tk webdav -xinetd" ABI_X86="(64)" PYTHON_SINGLE_TARGET="-python3_7 python3_8 -python3_9" * Package: dev-vcs/git-2.31.0 * Repository: gentoo * Maintainer: robbat2@gentoo.org polynomial-c@gentoo.org * USE: abi_x86_64 amd64 blksha1 curl cvs elibc_glibc emacs gpg iconv kernel_linux nls pcre perl python_single_target_python3_8 threads tk userland_GNU webdav * FEATURES: network-sandbox preserve-libs sandbox userpriv usersandbox >>> Unpacking source... >>> Unpacking git-2.31.0.tar.xz to /var/tmp/portage/dev-vcs/git-2.31.0/work >>> Unpacking git-manpages-2.31.0.tar.xz to /var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0 >>> Source unpacked in /var/tmp/portage/dev-vcs/git-2.31.0/work >>> Preparing source in /var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0 ... * Applying git-2.31.0_rc0-optional-cvs.patch ... [ ok ] * Applying git-2.21.0-quiet-submodules-testcase.patch ... patching file t/t7407-submodule-foreach.sh Hunk #1 succeeded at 431 with fuzz 1 (offset 20 lines). [ ok ] >>> Source prepared. >>> Configuring source in /var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0 ... >>> Source configured. >>> Compiling source in /var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0 ... make -j4 ASCIIDOC_NO_ROFF=YesPlease INSTALLDIRS=vendor NO_PERL_CPAN_FALLBACKS=YesPlease NO_PYTHON=YesPlease NO_SVN_TESTS=YesPlease BLK_SHA1=YesPlease NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease INSTALL=install TAR=tar SHELL_PATH=/bin/sh SANE_TOOL_PATH= OLD_ICONV= NO_EXTERNAL_GREP= USE_LIBPCRE1=YesPlease NO_LIBPCRE1_JIT=YesPlease ASCIIDOC8=YesPlease prefix=/usr htmldir=/usr/share/doc/git-2.31.0/html perllibdir=/usr/lib64/perl5/vendor_perl/5.32 sysconfdir=/etc DESTDIR=/var/tmp/portage/dev-vcs/git-2.31.0/image GIT_TEST_OPTS=--no-color OPTAR=x86_64-pc-linux-gnu-ar OPTCC=x86_64-pc-linux-gnu-gcc 'OPTCFLAGS=-march=native -O2 -pipe' 'OPTLDFLAGS=-Wl,-O1 -Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu -Wl,--enable-new-dtags' PERL_PATH=/usr/bin/perl PERL_MM_OPT= PYTHON_PATH= V=1 Makefile:1369: *** The USE_LIBPCRE1 build option has been removed, use version 2 with USE_LIBPCRE. Stop. * ERROR: dev-vcs/git-2.31.0::gentoo failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=dev-vcs/git-2.31.0::gentoo'`, * the complete build log and the output of `emerge -pqv '=dev-vcs/git-2.31.0::gentoo'`. * The complete build log is located at '/var/tmp/portage/dev-vcs/git-2.31.0/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/dev-vcs/git-2.31.0/temp/environment'. * Working directory: '/var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0' * S: '/var/tmp/portage/dev-vcs/git-2.31.0/work/git-2.31.0'
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=eea03066a24c86bb30037563d901a609c3060cfc commit eea03066a24c86bb30037563d901a609c3060cfc Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2021-03-16 13:18:06 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2021-03-16 13:19:43 +0000 dev-vcs/git: Removed pcre-jit USE flag because upstream removed support for libpcre-1. DroppedKeywords: version 2.31.0: alpha, hppa, ia64, riscv, sparc Closes: https://bugs.gentoo.org/776646 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> dev-vcs/git/git-2.31.0.ebuild | 22 +++++----------------- dev-vcs/git/git-9999-r1.ebuild | 20 ++++---------------- dev-vcs/git/git-9999-r2.ebuild | 20 ++++---------------- dev-vcs/git/git-9999-r3.ebuild | 20 ++++---------------- 4 files changed, 17 insertions(+), 65 deletions(-)
why was the pcre-jit use flag removed? JIT can have potential security implications, and keeping the pcre-jit use flag to allow to distinguish between pcre and pcre-jit is a good idea imo
(In reply to Herbert Wantesh from comment #3) > why was the pcre-jit use flag removed? > > JIT can have potential security implications, and keeping the pcre-jit use > flag to allow to distinguish between pcre and pcre-jit is a good idea imo Because libpcre1 support was dropped upstream. If you want to turn off JIT, please do it on libpcre2 itself. See also bug 776682.
