775593 – app-shells/pdsh-2.26-r1 main.c:(.text+0x265): undefined reference to `out' when using slibtool

Bug 775593 - app-shells/pdsh-2.26-r1 main.c:(.text+0x265): undefined reference to `out' when using slibtool

Summary: app-shells/pdsh-2.26-r1 main.c:(.text+0x265): undefined reference to `out' wh...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Cluster Team

URL:
Whiteboard:
Keywords:	PATCH, UPSTREAM

Depends on:
Blocks:	slibtool
	Show dependency tree

Reported:	2021-03-12 09:57 UTC by Alessandro Barbieri
Modified:	2021-08-13 18:24 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
pdsh-2.26-r1:20210312-094803.log (pdsh-2.26-r1:20210312-094803.log,134.41 KB, text/plain) 2021-03-12 09:57 UTC, Alessandro Barbieri	Details
https://github.com/chaos/pdsh/pull/130 (pdsh-slibtool.patch,790 bytes, patch) 2021-03-16 20:34 UTC, orbea	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alessandro Barbieri 2021-03-12 09:57:04 UTC

slibtool: link: x86_64-pc-linux-gnu-gcc ../../src/common/.libs/libcommon.a main.o dsh.o mod.o rcmd.o opt.o privsep.o pcp_server.o pcp_client.o testcase.o wcoll.o cbuf.o xpopen.o ltdl.o testconfig.o -Os -pipe -ma
rch=native -Os -pipe -march=native -Wimplicit-function-declaration -Wno-error=implicit-function-declaration -Wl,-O1 -Wl,--as-needed -pthread -lreadline -lhistory -lncurses -ldl -o .libs/pdsh -Wl,--export-dynamic
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: main.o: in function `_interactive_dsh':                                                                                            
main.c:(.text+0x265): undefined reference to `out'   


see log for more of the same

Comment 1 Alessandro Barbieri 2021-03-12 09:57:22 UTC

Created attachment 690948 [details]
pdsh-2.26-r1:20210312-094803.log

buildlog

Comment 2 orbea 2021-03-16 20:34:16 UTC

Created attachment 691869 [details, diff]
https://github.com/chaos/pdsh/pull/130

Comment 3 orbea 2021-03-16 20:35:46 UTC

I submitted a patch fixing this issue here.

https://github.com/chaos/pdsh/pull/130

Gentoo may also want to update pdsh using this repo?

Comment 4 Larry the Git Cow gentoo-dev

2021-03-16 21:41:06 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f058cd858fd7cb3d7c025f698c6baefc6661a1c

commit 2f058cd858fd7cb3d7c025f698c6baefc6661a1c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-03-16 21:40:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-03-16 21:40:07 +0000

    app-shells/pdsh: add 2.34
    
    Switches to a fork.
    
    Thanks-to: orbea <orbea@riseup.net>
    Closes: https://bugs.gentoo.org/775593
    Signed-off-by: Sam James <sam@gentoo.org>

 app-shells/pdsh/Manifest                       |  1 +
 app-shells/pdsh/files/pdsh-2.34-slibtool.patch | 20 ++++++++
 app-shells/pdsh/pdsh-2.34.ebuild               | 63 ++++++++++++++++++++++++++
 3 files changed, 84 insertions(+)

Comment 5 orbea 2021-08-13 18:24:11 UTC

This is now merged upstream.

https://github.com/chaos/pdsh/commit/49dfc7d64ab634c7086a29e60961672a45fbe27d