Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 774189 - gui-libs/display-manager-init: Alternate implementation
Summary: gui-libs/display-manager-init: Alternate implementation
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-04 16:15 UTC by Brian Evans
Modified: 2021-04-13 14:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/etc/rc.conf.d/display-manager.conf (display-manager.conf,1.61 KB, text/plain)
2021-03-04 16:17 UTC, Brian Evans
Details
/etc/init.d/lxdm (lxdm.ini.alt,391 bytes, text/plain)
2021-03-04 16:17 UTC, Brian Evans
Details
/etc/rc.conf.d/display-manager.conf (d-m.conf,1.61 KB, text/plain)
2021-03-10 00:11 UTC, Brian Evans
Details
/etc/init.d/xdm (lxdm,387 bytes, text/plain)
2021-03-10 00:11 UTC, Brian Evans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans Gentoo Infrastructure gentoo-dev 2021-03-04 16:15:09 UTC
I believe we can do better for all display managers than what exists now.

If we are going to make this change, let's do a complete rethink.

I suggest creating a new service script for each DM we have but put common functions easily accessible so users can know for certain which DM they are starting.

Examples attached
Comment 1 Brian Evans Gentoo Infrastructure gentoo-dev 2021-03-04 16:17:03 UTC
Created attachment 689340 [details]
/etc/rc.conf.d/display-manager.conf

Common function file saved into /etc/rc.conf.d/
Comment 2 Brian Evans Gentoo Infrastructure gentoo-dev 2021-03-04 16:17:46 UTC
Created attachment 689343 [details]
/etc/init.d/lxdm

Sample DM script
Comment 3 Matt Turner gentoo-dev 2021-03-09 16:08:02 UTC
Aisha: please review.
Comment 4 Brian Evans Gentoo Infrastructure gentoo-dev 2021-03-10 00:11:04 UTC
Created attachment 690399 [details]
/etc/rc.conf.d/display-manager.conf

looks like hyphens are not allowed, removed
Comment 5 Brian Evans Gentoo Infrastructure gentoo-dev 2021-03-10 00:11:59 UTC
Created attachment 690402 [details]
/etc/init.d/xdm

Updated to match other attachment
Comment 6 William Hubbs gentoo-dev 2021-03-27 20:07:01 UTC
Code should not be put in /etc/rc.conf.d. This directory exists to allow
overriding configuration settings in /etc/rc.conf without touching this
file. If you put code there, it becomes available to all service scripts
on user's systems.

Also, with the approach on bug #768729, the display manager is manually
picked in /etc/conf.d/display-manager, so I'm not sure what your concern
is about users not knowing for certain which display manager they are
starting.
Comment 7 Brian Evans Gentoo Infrastructure gentoo-dev 2021-04-08 12:50:41 UTC
(In reply to William Hubbs from comment #6)
> Code should not be put in /etc/rc.conf.d. This directory exists to allow
> overriding configuration settings in /etc/rc.conf without touching this
> file. If you put code there, it becomes available to all service scripts
> on user's systems.
> 

Ok, the location really does not matter to me.  It was just a way to load automatically.  I see that sourcing can be done from any location so that would be the fine.

The point here is to have a common functions with varying commands and options and not have to hack the script every time a new DM appears.  I mean, that's what started all this to begin with.