I believe we can do better for all display managers than what exists now.
If we are going to make this change, let's do a complete rethink.
I suggest creating a new service script for each DM we have but put common functions easily accessible so users can know for certain which DM they are starting.
Created attachment 689340 [details]
Common function file saved into /etc/rc.conf.d/
Created attachment 689343 [details]
Sample DM script
Aisha: please review.
Created attachment 690399 [details]
looks like hyphens are not allowed, removed
Created attachment 690402 [details]
Updated to match other attachment
Code should not be put in /etc/rc.conf.d. This directory exists to allow
overriding configuration settings in /etc/rc.conf without touching this
file. If you put code there, it becomes available to all service scripts
on user's systems.
Also, with the approach on bug #768729, the display manager is manually
picked in /etc/conf.d/display-manager, so I'm not sure what your concern
is about users not knowing for certain which display manager they are
(In reply to William Hubbs from comment #6)
> Code should not be put in /etc/rc.conf.d. This directory exists to allow
> overriding configuration settings in /etc/rc.conf without touching this
> file. If you put code there, it becomes available to all service scripts
> on user's systems.
Ok, the location really does not matter to me. It was just a way to load automatically. I see that sourcing can be done from any location so that would be the fine.
The point here is to have a common functions with varying commands and options and not have to hack the script every time a new DM appears. I mean, that's what started all this to begin with.