Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 773100 - media-libs/libdvbcsa: EAPI 7 request, fix SIMD
Summary: media-libs/libdvbcsa: EAPI 7 request, fix SIMD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: James Le Cuirot
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: EAPI6Removal CPU_FLAGS_PPC
  Show dependency tree
 
Reported: 2021-02-26 17:29 UTC by David Michael
Modified: 2021-06-03 06:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix.patch (0001-media-libs-libdvbcsa-EAPI-7-fix-SIMD-drop-static-lib.patch,2.07 KB, patch)
2021-02-26 17:32 UTC, David Michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2021-02-26 17:29:52 UTC
Here is an updated ebuild for EAPI 7, CPU_FLAGS_PPC, and it fixes enabling SSE2 support.

It could probably be keyworded for ppc/ppc64 since it explicitly supports it, but it no longer compiles with AltiVec since modern GCC seem to be more strict about intrinsics usage, so cpu_flags_ppc_altivec should be masked for that.
Comment 1 David Michael 2021-02-26 17:32:59 UTC
Created attachment 688506 [details, diff]
fix.patch
Comment 2 Larry the Git Cow gentoo-dev 2021-03-21 19:00:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e967baacf89e82913e38d733f6d8a6f6f19fd6a

commit 3e967baacf89e82913e38d733f6d8a6f6f19fd6a
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2021-03-21 19:00:23 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-03-21 19:00:23 +0000

    media-libs/libdvbcsa: EAPI 7, fix SIMD, drop static-libs
    
    The previous revision would not actually use SSE2 if MMX was also
    enabled.
    
    This also drops the explicit int size specification for amd64/x86
    since these values are automatically determined, and they apply for
    other architectures as well.  (It computes the size of long for the
    default option, and this value is cached in a CONFIG_SITE file with
    crossdev, so it works everywhere.)
    
    Closes: https://bugs.gentoo.org/773100
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 media-libs/libdvbcsa/libdvbcsa-1.1.0-r1.ebuild | 41 ++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2021-06-03 06:21:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f88fe32442b93604890333140cb399826c4e95f9

commit f88fe32442b93604890333140cb399826c4e95f9
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-06-03 06:19:07 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-06-03 06:21:33 +0000

    media-libs/libdvbcsa: add ppc keyword
    
    Bug: https://bugs.gentoo.org/773100
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 media-libs/libdvbcsa/libdvbcsa-1.1.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ae527ccb005f448c1de107332cf5fbe9e28d236

commit 5ae527ccb005f448c1de107332cf5fbe9e28d236
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-06-03 06:10:46 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-06-03 06:21:33 +0000

    media-libs/libdvbcsa: keyword 1.1.0-r1 for ~ppc64
    
    Bug: https://bugs.gentoo.org/773100
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 media-libs/libdvbcsa/files/altivec.patch       | 33 ++++++++++++++++++++++++++
 media-libs/libdvbcsa/libdvbcsa-1.1.0-r1.ebuild |  8 ++++++-
 2 files changed, 40 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9122ec624d069dc4fcc3eb31faace59e52e3d1cf

commit 9122ec624d069dc4fcc3eb31faace59e52e3d1cf
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-06-03 06:17:40 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-06-03 06:21:14 +0000

    profiles/arch/powerpc/ppc64/64le: mask altivec for dvbcsa
    
    Bug: https://bugs.gentoo.org/773100
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 profiles/arch/powerpc/ppc64/64le/package.use.mask | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 4 Georgy Yakovlev archtester gentoo-dev 2021-06-03 06:22:25 UTC
altivec patch from buildroot:
https://github.com/buildroot/buildroot/blob/master/package/libdvbcsa/0001-altivec-powerpc64.patch

adding it + passing -flax-verctor-conversions fixes build

but only on big-endian ppc64 and ppc32

ppc64le test failures look like classic endianess problem. so I masked there.