Accepting a license should always be a conscious choice of the user and never happen automatically. The user may even get into legal trouble if licenses are unmasked behind his back. Therefore I'd strongly suggest --autounmask-license to be disabled by default. Users who want that feature could still explicitly enable it in their EMERGE_DEFAULT_OPTS.
Yes, sounds reasonable. A small change like this should do it: > diff --git a/lib/_emerge/create_depgraph_params.py b/lib/_emerge/create_depgraph_params.py > index 0d0e07b9c..b9e944313 100644 > --- a/lib/_emerge/create_depgraph_params.py > +++ b/lib/_emerge/create_depgraph_params.py > @@ -54,5 +54,5 @@ def create_depgraph_params(myopts, myaction): > if autounmask_use in (None, 'y'): > autounmask = True > - elif autounmask_license in (None, 'y'): > + elif autounmask_license in ('y',): > autounmask = True
Patch posted for review: https://archives.gentoo.org/gentoo-portage-dev/message/c50082bba4b55eac90bcdeabb6d3d8e1 https://github.com/gentoo/portage/pull/666
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=3c587280434d7f36a45117ed0732362b9c49018f commit 3c587280434d7f36a45117ed0732362b9c49018f Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2021-01-24 02:41:41 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2021-02-08 04:22:54 +0000 emerge: disable --autounmask-license by default Disable --autounmask-license by default, in order to limit user exposure to risks associated with package.license changes. The changes that this option suggests are only intended to be accepted when a user has made a conscious decision to accept the corresponding license(s). Creation of package.license changes introduces a risk that users may erroneously accept the changes due to some kind of accident or misunderstanding, rather than due to conscious decisions about licenses. These risks provide motivation to disable --autounmask-license by default. The --autounmask-use option will remain as the only autounmask option that is still enabled by default. The unit tests demonstrate interactions between --autounmask and --autounmask-license options. The --autounmask option enables --autounmask-license unless --autounmask-license=n has been specified. If --autounmask=n is used to disable autounmask, then --autounmask-license=y has no effect. Bug: https://bugs.gentoo.org/766773 Reviewed-by: Brian Dolbec <dolsen@gentoo.org> Signed-off-by: Zac Medico <zmedico@gentoo.org> lib/_emerge/create_depgraph_params.py | 8 ++++---- lib/portage/tests/resolver/test_autounmask.py | 25 +++++++++++++++++++++++-- man/emerge.1 | 11 ++++------- 3 files changed, 31 insertions(+), 13 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b98e103aa15da331d647a8f65a45bb3bb4e3197 commit 6b98e103aa15da331d647a8f65a45bb3bb4e3197 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2021-02-22 13:46:04 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2021-02-22 13:54:29 +0000 sys-apps/portage: Bump to version 3.0.15 #715112 default enable FEATURES=binpkg-multi-instance #756778 content-hash distfiles layout #766459 emirrordist: prevent distfiles_db _pkg_str pickle problems #766767 emaint --fix merges: add -y, --yes option #766773 emerge: disable --autounmask-license by default #767913 portage.getpid: call os.getpid() lazily #770712 PopenProcess: use call_soon for _async_waipid in _start #771549 prevent USE="${USE} ..." misbehavior Bug: https://bugs.gentoo.org/766117 Bug: https://bugs.gentoo.org/715112 Bug: https://bugs.gentoo.org/756778 Bug: https://bugs.gentoo.org/766459 Bug: https://bugs.gentoo.org/766767 Bug: https://bugs.gentoo.org/766773 Bug: https://bugs.gentoo.org/767913 Bug: https://bugs.gentoo.org/770712 Bug: https://bugs.gentoo.org/771549 Package-Manager: Portage-3.0.15, Repoman-3.0.2 Signed-off-by: Zac Medico <zmedico@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-3.0.15.ebuild | 268 +++++++++++++++++++++++++++++++++ 2 files changed, 269 insertions(+)
