Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764959 - games-arcade/supertux with media-libs/libsdl2-2.0.14 moves entire HOME directory contents away
Summary: games-arcade/supertux with media-libs/libsdl2-2.0.14 moves entire HOME direct...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Gentoo Games
URL: https://github.com/SuperTux/supertux/...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-01-11 12:50 UTC by Arusekk
Modified: 2022-08-27 10:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arusekk 2021-01-11 12:50:20 UTC
DO NOT LAUNCH supertux before reading the *entire* report. It will corrupt your user data.

Every file and directory from $HOME is moved into ~/.local/share/supertux2.

The thing is that in main.cpp:249 the variable olduserdir gets assigned "/home/username/." instead of "/home/username/.supertux2".
So PACKAGE_NAME is set either to an empty string or nothing, while it should be "supertux2".
Strange enough, in command_line_arguments.cpp:128 it is set correctly. And it is set to "supertux2" by default in config.h.cmake, so not reporting upstream, but here.

Reproducible: Always

Steps to Reproduce:
1. Make a backup of $HOME. You can skip this step if using a temporary user account.
1.5. might be necessary to create ~/.supertux2
2. Launch supertux (careful, happens even with --help or --version).
Actual Results:  
My files are moved away.

Expected Results:  
They stay in place.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-01-11 13:05:32 UTC
See also: https://forums.gentoo.org/viewtopic-t-1126888.html
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-11 13:26:35 UTC
OMG! Thanks for your thorough analysis. I will try to fix this ASAP.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-11 13:47:28 UTC
For the sake of completeness, can you please post the following command output as comment into this bug?

  emerge --info games-arcade/supertux
Comment 4 Arusekk 2021-01-11 13:56:05 UTC
$ emerge --info games-arcade/supertux

Portage 3.0.13 (python 3.6.12-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-10.2.0, glibc-2.32-r7, 5.10.3-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.10.3-gentoo-x86_64-Intel-R-_Core-TM-_i5-4200M_CPU_@_2.50GHz-with-gentoo-2.7
KiB Mem:     7873904 total,   3384008 free
KiB Swap:   16777212 total,  16774884 free
Timestamp of repository gentoo: Mon, 11 Jan 2021 11:00:01 +0000
Head commit of repository gentoo: f088a76c0c43d5de7c53d25d2ecfdc2c97ff8679
Head commit of repository SonicFrog: 622820c0d120a1d2f20ca9b0b4c8d7e89a9aaf9c

Timestamp of repository guru: Mon, 11 Jan 2021 07:35:16 +0000
Head commit of repository guru: bd39653c4be82fee25251c0a8801ad4c4334356f

Timestamp of repository matrix: Tue, 05 Jan 2021 23:59:25 +0000
Head commit of repository matrix: e409554200499097381cb3653d88fbcbf1be8196

Timestamp of repository pentoo: Wed, 14 Oct 2020 01:35:02 +0000
Head commit of repository pentoo: 89aee8bd643efc296f85ef6df8059c3984184c4e

sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
ccache version 4.1 [enabled]
app-shells/bash:          5.1_p4::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.32.0-r1::gentoo
dev-lang/python:          2.7.18-r5::gentoo, 3.7.9-r1::gentoo, 3.8.7::gentoo, 3.9.1::gentoo
dev-util/ccache:          4.1::gentoo
dev-util/cmake:           3.19.2::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.3.2-r1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

SonicFrog
    location: /var/db/repos/SonicFrog
    sync-type: git
    sync-uri: https://github.com/SonicFrog/overlay
    masters: gentoo

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo

localrepo
    location: /usr/local/portage
    masters: gentoo

matrix
    location: /var/db/repos/matrix
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/matrix.git
    masters: gentoo

pentoo
    location: /var/db/repos/pentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/pentoo.git
    masters: gentoo

crossdev
    location: /usr/local/portage-crossdev
    masters: gentoo
    priority: 10

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=haswell -mabm"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.6/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.0/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=haswell -mabm"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=haswell -mabm"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=haswell -mabm"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="pl_PL.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="pl"
MAKEOPTS="-j5"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 autocrypt berkdb bluetooth branding bzip2 cairo capstone ccache cdda cdr cli crypt cups dbus declarative device-mapper dri dts dvd dvdr efi efiemu elogind emboss encode eselect-ldso exif fbcon ffmpeg flac fortran gdbm geckodriver gif git gpgme gpm grub gstreamer gtk gui hwaccel iconv icu ipv6 joystick jpeg kde kipi kwallet lcms libglvnd libnotify libtirpc logrotate lspclient lto lz4 lzo mad mbox midi mng mp3 mp4 mpeg mtp multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma plymouth png policykit ppds pulseaudio python qml qrcode qt5 readline sddm sdl seccomp semantic-desktop spell split-usr sqlite ssl startup-notification svg symlink synaptics tcpd thumbnail tiff timidity touchpad truetype udev udisks unicode upower usb v4l vim-syntax vorbis widgets wxwidgets x264 xattr xcb xface xinerama xml xv xvid zeroconf zlib zsh-completion zstd" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="pl" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python2_7 python3_7 python3_8 python3_9 pypy3" QEMU_SOFTMMU_TARGETS="arm x86_64" QEMU_USER_TARGETS="arm mips mips64 mips64el mipsel ppc ppc64 sparc64 aarch64 x86_64" RUBY_TARGETS="ruby25 ruby26" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

games-arcade/supertux-0.6.2::gentoo was built with the following:
USE="-debug" ABI_X86="(64)"
CFLAGS="-O2 -pipe -march=haswell -mabm -ggdb"
CXXFLAGS="-O2 -pipe -march=haswell -mabm -ggdb -std=c++11"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs ccache compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles installsources ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
Comment 5 James Le Cuirot gentoo-dev 2021-01-11 14:08:53 UTC
Yikes! I actually ran this the other day. It didn't happen to me, perhaps because I was running the older 0.6.2_rc1?

Thanks for handling this, Lars.
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-11 14:28:52 UTC
Okay, I have trouble reproducing this issue. And before I start pestering upstream about this I'd like to have some uncertainties clarified...

@Arusekk: Can you please disable ccache, rebuild supertux, try to reproduce the issue and report your result here. Also, please make sure that you have the following packages installed from ::gentoo repo and not from some overlay:

  dev-games/physfs
  dev-libs/boost
  media-libs/libsdl2
Comment 7 Arusekk 2021-01-11 14:54:21 UTC
I just had a look at the compilation logs and found many of these warnings:

[ 70%] Building CXX object CMakeFiles/supertux2_lib.dir/src/supertux/levelintro.cpp.o
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++  -I/var/tmp/portage/games-arcade/supertux-0.6.2/work/supertux-0.6.2_build -I/var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src -isystem /usr/include/AL -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/supertux-0.6.2_build/squirrel/ex/include -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/supertux-0.6.2_build/tinygettext/include -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/supertux-0.6.2_build/SDL_ttf/include/SDL2 -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/external/findlocale -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/external/sexp-cpp/include -isystem /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/external/SDL_SavePNG -isystem /usr/include/SDL2  -O2 -pipe -march=haswell -mabm -ggdb -std=c++11 -Wall -Wextra -Wno-unused-parameter -funit-at-a-time -fno-strict-aliasing -std=c++14 -o CMakeFiles/supertux2_lib.dir/src/supertux/levelintro.cpp.o -c /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/supertux/levelintro.cpp
In file included from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/video/gl.hpp:20,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/video/blend.hpp:23,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/video/canvas.hpp:28,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/sprite/sprite.hpp:22,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/supertux/levelintro.cpp:21:
/var/tmp/portage/games-arcade/supertux-0.6.2/work/supertux-0.6.2_build/config.h:4: warning: "PACKAGE_NAME" redefined
    4 | #define PACKAGE_NAME "supertux2"
      | 
In file included from /usr/include/SDL2/SDL_config.h:10,
                 from /usr/include/SDL2/SDL_assert.h:25,
                 from /usr/include/SDL2/SDL.h:34,
                 from /usr/include/SDL2/SDL_image.h:27,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/video/color.hpp:24,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/supertux/levelintro.hpp:23,
                 from /var/tmp/portage/games-arcade/supertux-0.6.2/work/SuperTux-v0.6.2-Source/src/supertux/levelintro.cpp:17:
/usr/include/x86_64-pc-linux-gnu/SDL2/SDL_config.h:521: note: this is the location of the previous definition
  521 | #define PACKAGE_NAME ""
      | 

So I guess depending o the order of includes this might cause supertux to move around your data, or not to.
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-01-11 15:03:25 UTC
Yes, this is caused by media-libs/libsdl2-2.0.14:

# qlist -Ce libsdl2 | grep '\.h' | xargs grep -F PACKAGE_NAME
/usr/include/i686-pc-linux-gnu/SDL2/SDL_config.h:#define PACKAGE_NAME ""
/usr/include/x86_64-pc-linux-gnu/SDL2/SDL_config.h:#define PACKAGE_NAME ""
Comment 9 Larry the Git Cow gentoo-dev 2021-01-11 15:59:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d70fb9b34f2a8784218a7b3d06bb19882501f654

commit d70fb9b34f2a8784218a7b3d06bb19882501f654
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-01-11 15:46:06 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-01-11 15:59:47 +0000

    games-arcade/supertux: Revbump to fix severe issue with libsdl2-2.0.14
    
    Bug: https://bugs.gentoo.org/764959
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../supertux/{supertux-0.6.2.ebuild => supertux-0.6.2-r1.ebuild}      | 4 ++++
 1 file changed, 4 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2021-01-11 16:45:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af43ef670c3d235a35d86f3ac22dde0c242d2ca2

commit af43ef670c3d235a35d86f3ac22dde0c242d2ca2
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2021-01-11 16:40:15 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2021-01-11 16:45:48 +0000

    media-libs/libsdl2: stub-out eautoheader
    
    Closes: https://bugs.gentoo.org/764959
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../libsdl2/{libsdl2-2.0.14.ebuild => libsdl2-2.0.14-r1.ebuild}      | 5 +++++
 1 file changed, 5 insertions(+)
Comment 11 Larry the Git Cow gentoo-dev 2021-01-11 18:33:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec26ad9b5eedb96d8b10d1bae438e8355b44c978

commit ec26ad9b5eedb96d8b10d1bae438e8355b44c978
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-01-11 17:18:03 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-01-11 18:33:25 +0000

    autotools.eclass: Introduce AT_NOEAUTOHEADER variable
    
    Sometimes packages get their headers being broken by autoheader (see
    media-libs/freetype for example) or get unwanted defines added (see
    media-libs/libsdl2). In that case we want to run eautoreconf without
    call to eautoheader.
    
    Bug: https://bugs.gentoo.org/764959
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 eclass/autotools.eclass | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Comment 12 Arusekk 2021-01-11 19:50:18 UTC
For anyone who lands here and wants to recover their files and config, if you launched supertux only once (because default files could be recreated and moved there once again), they are all safe in ~/.local/share/supertux2/, just move them back to your home directory and everything will hopefully work again.