Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 762631 - app-emulation/libvirt should RDEPEND on acct-user/qemu and acct-group/libvirt
Summary: app-emulation/libvirt should RDEPEND on acct-user/qemu and acct-group/libvirt
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-30 11:46 UTC by Garry Filakhtov
Modified: 2021-02-17 02:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Garry Filakhtov 2020-12-30 11:46:04 UTC
Current app-emulation/libvirt package ebuilds have acct-user/qemu and, if policykit flag is enabled, acct-group/libvirt packages as the build dependencies (BDEPEND).

As an example, this leads to users and groups not being properly created inside of the target root directory if running emerge with a different root (--root command line switch or ROOT= environment variable) directory, but there likely are more use cases that will have issues.

acct-*/* dependencies should be RDEPEND instead.
Comment 1 Ionen Wolkens gentoo-dev 2020-12-30 12:58:27 UTC
Yes, and as far as I'm aware BDEPEND shouldn't be used for this (either DEPEND+RDEPEND or just RDEPEND).
Comment 2 Larry the Git Cow gentoo-dev 2021-01-17 04:34:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6936bffc32ecec1ab4f4784dd52a16e9429e556

commit f6936bffc32ecec1ab4f4784dd52a16e9429e556
Author:     Jonathan Davies <jpds@protonmail.com>
AuthorDate: 2021-01-15 14:39:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-01-17 04:34:29 +0000

    app-emulation/libvirt: Version updated to 7.0.0, with changes:
    
    * Moved acct-*/* dependencies to RDEPEND:
      Closes: https://bugs.gentoo.org/762631
    * Removed 6.10.0-Fix-segfault-when-parsing-mdev-types.patch: applied
      upstream.
    
    Signed-off-by: Jonathan Davies <jpds@protonmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/19066
    Signed-off-by: Sam James <sam@gentoo.org>

 app-emulation/libvirt/Manifest             |   1 +
 app-emulation/libvirt/libvirt-7.0.0.ebuild | 331 +++++++++++++++++++++++++++++
 2 files changed, 332 insertions(+)