Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759289 - games-arcade/cdogs-sdl-0.10.1 uses -Werror for build
Summary: games-arcade/cdogs-sdl-0.10.1 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-12-09 23:32 UTC by Agostino Sarubbo
Modified: 2020-12-10 21:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-12-09 23:32:36 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-arcade/cdogs-sdl-0.10.1 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2020-12-10 21:16:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=41863e453687ebc1a83991166d16461f0d191936

commit 41863e453687ebc1a83991166d16461f0d191936
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2020-12-10 12:11:17 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-12-10 21:16:06 +0000

    games-arcade/cdogs-sdl: Remove -Werror for build
    
    Closes: https://bugs.gentoo.org/759289
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/18594
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-arcade/cdogs-sdl/cdogs-sdl-0.10.1.ebuild     |  1 +
 ...0.1-Remove-Winline-and-Werror-definitions.patch | 24 ++++++++++++++++++++++
 2 files changed, 25 insertions(+)