Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758386 - net-misc/unison-2.51.3_p20201024: No graphical UI despite gtk use flag
Summary: net-misc/unison-2.51.3_p20201024: No graphical UI despite gtk use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-12-04 13:25 UTC by Stefan Huber
Modified: 2021-03-05 19:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Huber 2020-12-04 13:25:26 UTC
Emerging unison-2.51.3_p20201024 with use flags "doc gtk ocamlopt -debug -threads" does not build a unison with graphical user interface:

% unison-2.51 -ui graphic
This Unison binary only provides the text GUI...

It works, however, for unison-2.48.15_p4-r2.

This bug might be related to bug #750125.


Reproducible: Always
Comment 1 Stefan Huber 2020-12-04 13:31:40 UTC
Also, it works for unison-2.51.3_p20201024 if I remove the "doc" use flag, which in light of bug #750125 is probably related to this snippet of the ebuild:

# build unison-manual.pdf but not .html
if use doc; then
	local myconf="all docs HEVEA=false"
else
	local myconf="all"
fi

Note that the ebuild of unison-2.48.15_p4-r2 does change myconf depending on the doc use flag, but the 2.51.3_p20201024 ebuild does.
Comment 2 Volkmar W. Pogatzki 2020-12-04 23:48:53 UTC
Waiting for https://github.com/bcpierce00/unison/issues/416
Comment 3 Volkmar W. Pogatzki 2020-12-05 00:58:23 UTC
This workaround does it for me:

First emerge with USE flags
"doc -gtk ocamlopt -debug -threads"

Followed by emerge with USE flags
"doc gtk ocamlopt -debug -threads"

Still need to find a way to do this in the ebuild.
Comment 4 Volkmar W. Pogatzki 2020-12-05 01:53:51 UTC
Changed the ebuild to using

if use doc; then
   myconf="all docs HEVEA=false"
   emake $myconf CFLAGS=""
fi

https://github.com/gentoo/gentoo/pull/18433
Comment 5 Larry the Git Cow gentoo-dev 2020-12-15 04:06:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43f5f02c5f036d7a9d73f0a621d81b734e74913a

commit 43f5f02c5f036d7a9d73f0a621d81b734e74913a
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2020-11-27 18:13:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-12-15 04:00:36 +0000

    net-misc/unison: bump to 2.51.3_p20201127
    
    Closes: https://bugs.gentoo.org/758386
    
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/unison/Manifest                       |   1 +
 net-misc/unison/metadata.xml                   |   8 +-
 net-misc/unison/unison-2.51.3_p20201127.ebuild | 111 +++++++++++++++++++++++++
 3 files changed, 119 insertions(+), 1 deletion(-)
Comment 6 Till Schäfer 2020-12-15 09:10:24 UTC
Why was a stable ebuild removed without stabilizing the successor first? This leads to downgrading of unison for many users to an older version (which might cause compatibility problems) 
BTW: GUI was working for me with the current stable removed.
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-12-15 09:21:31 UTC
(In reply to Till Schäfer from comment #6)
> Why was a stable ebuild removed without stabilizing the successor first?
> This leads to downgrading of unison for many users to an older version
> (which might cause compatibility problems) 
> BTW: GUI was working for me with the current stable removed.

I apologise: it was a mistake and I should have caught it in review. I’ll restore the version shortly.

Can you confirm it works with the latest ~ version by the way?
Comment 8 Stefan Huber 2020-12-15 09:26:28 UTC
(In reply to Sam James from comment #7)
> Can you confirm it works with the latest ~ version by the way?

No, it does not:

% unison-2.51 -ui graphic
This Unison binary only provides the text GUI...

% eix -e unison -c
[I] net-misc/unison (2.48.15_p4-r2(2.48)@04.12.2020 2.51.3_p20201127(2.51)@15.12.2020)
Comment 9 Volkmar W. Pogatzki 2021-01-12 12:57:02 UTC
(In reply to Stefan Huber from comment #8)
> (In reply to Sam James from comment #7)
> > Can you confirm it works with the latest ~ version by the way?
> 
> No, it does not:
> 
> % unison-2.51 -ui graphic
> This Unison binary only provides the text GUI...
> 
> % eix -e unison -c
> [I] net-misc/unison (2.48.15_p4-r2(2.48)@04.12.2020
> 2.51.3_p20201127(2.51)@15.12.2020)

PR https://github.com/gentoo/gentoo/pull/19043 should solve it by changing the order:  https://github.com/gentoo/gentoo/pull/19043/commits/5fa75bcfef61d11c43e399a1169050f6911b1f4e#diff-d99a779cbbef6de291f4750d1e5ce17aa145c8ae6478baddb75e15bb28757437R57-R62
Comment 10 Larry the Git Cow gentoo-dev 2021-03-05 19:56:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=193dfb05dd5d2b884574f78a6f5972bf2781d6f6

commit 193dfb05dd5d2b884574f78a6f5972bf2781d6f6
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2021-01-27 11:57:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-03-05 19:56:46 +0000

    net-misc/unison: fix graphical UI logic in 2.51.3_p20201127
    
    Use same logic as 2.51.4_rc1.
    
    Bug: https://bugs.gentoo.org/758386
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/19043
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/unison/unison-2.51.3_p20201127.ebuild | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)