Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 757756 - dev-qt/qt-creator unmask clang USE and remove libclangformat-ide dependency
Summary: dev-qt/qt-creator unmask clang USE and remove libclangformat-ide dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Davide Pesavento
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-11-30 14:18 UTC by Sergej Petrushkin
Modified: 2021-07-12 17:00 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info llvm clang clang-runtime qt-creator (emerge_info_qt-creator.txt,11.63 KB, text/plain)
2020-11-30 14:18 UTC, Sergej Petrushkin
Details
ebuild patch (qt-designer-ebuild.patch,952 bytes, patch)
2020-11-30 14:19 UTC, Sergej Petrushkin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergej Petrushkin 2020-11-30 14:18:05 UTC
Created attachment 675826 [details]
emerge --info llvm clang clang-runtime qt-creator

USE flag dev-qt/qt-creator clang is masked due to removal of libclangformat-ide. But qt-creator builds with sys-devel/clang:10, and the ClangCodeModel plugin works well. I think it is better to remove libclangformat-ide from dependencies and unmask the clang USE.
Comment 1 Sergej Petrushkin 2020-11-30 14:19:49 UTC
Created attachment 675829 [details, diff]
ebuild patch
Comment 2 Victor Mataré 2020-12-01 16:58:46 UTC
Absolutely. I can understand rage-removing unmaintained packages, but this is throwing the child out with the bathwater. libclangformat deals just with code formatting. No reason to kill the entire clang code model support with it.

Also after this is done, please unmask the clang USE flag on qt-creator again.
Comment 3 Peter Levine 2020-12-02 07:59:33 UTC
As the author of the libclangformat-ide ebuild, I can't blame anyone for not wanting to maintain it.  Still, there were other solutions like https://github.com/Peter-Levine/gentoo/commit/f486cad9ef31d8b1971b047629ca371ccbb87dab, ideally using a separate "clangformat" USE flag instead of "clang".
Comment 4 Dmitry Grigoriev 2020-12-04 15:18:25 UTC
I agreed, complained about the same here: https://bugs.gentoo.org/734732#c10
Comment 5 Larry the Git Cow gentoo-dev 2021-07-11 05:37:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6071107a60004a01f2a5a5085c2fc2f42014083f

commit 6071107a60004a01f2a5a5085c2fc2f42014083f
Author:     Davide Pesavento <pesa@gentoo.org>
AuthorDate: 2021-07-11 05:34:04 +0000
Commit:     Davide Pesavento <pesa@gentoo.org>
CommitDate: 2021-07-11 05:34:04 +0000

    profiles/base/package.use.mask: drop obsolete entry for qt-creator
    
    Bug: https://bugs.gentoo.org/757756
    Signed-off-by: Davide Pesavento <pesa@gentoo.org>

 profiles/base/package.use.mask | 4 ----
 1 file changed, 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69c7ab38c931d19f61adb59bebadecc2ca598632

commit 69c7ab38c931d19f61adb59bebadecc2ca598632
Author:     Davide Pesavento <pesa@gentoo.org>
AuthorDate: 2021-07-11 05:29:54 +0000
Commit:     Davide Pesavento <pesa@gentoo.org>
CommitDate: 2021-07-11 05:29:54 +0000

    dev-qt/qt-creator: remove half-broken 4.12.3-r1
    
    Bug: https://bugs.gentoo.org/757756
    Package-Manager: Portage-3.0.20, Repoman-3.0.3
    Signed-off-by: Davide Pesavento <pesa@gentoo.org>

 dev-qt/qt-creator/Manifest                         |   1 -
 .../files/qt-creator-4.12.0-dylib-fix.patch        |  84 --------
 .../qt-creator-4.12.0-libclangformat-ide.patch     |  64 ------
 dev-qt/qt-creator/metadata.xml                     |   2 -
 dev-qt/qt-creator/qt-creator-4.12.3-r1.ebuild      | 235 ---------------------
 5 files changed, 386 deletions(-)
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2021-07-11 05:41:51 UTC
Fixed in 4.15.1