Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753941 - dev-python/urllib3: bundles six and more libs
Summary: dev-python/urllib3: bundles six and more libs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: bundled-libs
  Show dependency tree
 
Reported: 2020-11-10 21:09 UTC by Michał Górny
Modified: 2022-06-18 08:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-11-10 21:09:02 UTC
Need to investigate why and if we can unbundle.
Comment 1 Larry the Git Cow gentoo-dev 2022-06-17 11:01:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=64005a7a7408abded90246d50085b654a4b5b730

commit 64005a7a7408abded90246d50085b654a4b5b730
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-06-17 08:00:16 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-06-17 11:01:08 +0000

    dev-python/urllib3: Unbundle six
    
    Closes: https://bugs.gentoo.org/753941
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/urllib3/urllib3-1.26.9-r2.ebuild | 74 +++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)
Comment 2 Joonas Niilola gentoo-dev 2022-06-18 05:24:45 UTC
After updating my system, I'm getting:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.10/pfl", line 4, in <module>
    import pfl.pfl
  File "/usr/lib/python3.10/site-packages/pfl/pfl.py", line 8, in <module>
    import requests
  File "/usr/lib/python3.10/site-packages/requests/__init__.py", line 43, in <module>
    import urllib3
  File "/usr/lib/python3.10/site-packages/urllib3/__init__.py", line 11, in <module>
    from . import exceptions
  File "/usr/lib/python3.10/site-packages/urllib3/exceptions.py", line 3, in <module>
    from six.moves.http_client import IncompleteRead as httplib_IncompleteRead
ModuleNotFoundError: No module named 'six'

which seems to come from urllib3 now. So my guess is after unbundling six you now need to RDEPEND on the system one.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-06-18 06:26:41 UTC
You're right, I'm really sorry about that.  I have a fix queued and will push ASAP.
Comment 4 Joonas Niilola gentoo-dev 2022-06-18 08:01:29 UTC
Thanks for reacting swiftly! While nothing serious broke for me, urllib3 does seem to have some big rdeps. Don't be so hard on yourself, we found and fixed the issue really fast.