Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753497 - sys-apps/portage: profiles should not be reported as deprecated when they inherit a deprecated profile
Summary: sys-apps/portage: profiles should not be reported as deprecated when they inh...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 563798 756028
  Show dependency tree
 
Reported: 2020-11-07 17:17 UTC by Zac Medico
Modified: 2022-04-14 03:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2020-11-07 17:17:32 UTC
This is covered in PMS section 5.2.3:

https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-460005.2.3

This file is not inherited—profiles which inherit from a deprecated profile are not deprecated.
Comment 1 Zac Medico gentoo-dev 2020-11-07 19:50:57 UTC
It's complicated by the fact that the list of profile directories includes /etc/portage/profile if it exists, and /etc/portage/make.profile can be a regular directory with a parent file that inherits from a deprecated profile.
Comment 2 Michael 'veremitz' Everitt 2020-11-08 21:17:08 UTC
Surely a quick recursive traversal of the profile 'tree' with a marker flag should negate the 'deprecated' state? Instead of what I suspect is probably the reverse logic, whereby its deprecated-by-default ?
Comment 3 Zac Medico gentoo-dev 2020-11-08 23:45:44 UTC
Will have to update the LocationsManager._addProfile method to link each profile node to its parent node.
Comment 5 Jory A. Pratt gentoo-dev 2020-11-11 17:17:04 UTC
(In reply to Zac Medico from comment #4)
> Patch posted for review:
> 
> https://archives.gentoo.org/gentoo-portage-dev/message/
> 000875711c3b7913a30930d7f3850ff1
> https://github.com/gentoo/portage/pull/635

ack, tested on amd64 and arm64 musl machines. no longer receiving false profile depreciation message.
Comment 6 Larry the Git Cow gentoo-dev 2020-11-22 00:53:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=309e28b2da9a7e98039b45e7555833fe6a4bc2f9

commit 309e28b2da9a7e98039b45e7555833fe6a4bc2f9
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-11-09 02:41:36 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-11-22 00:45:46 +0000

    emerge: Disable profile deprecation warning inheritance (bug 753497)
    
    According to PMS, a deprecated profile warning is not inherited. Since
    the current profile node may have been inherited by a user profile
    node, the deprecation warning may be relevant even if it is not a
    top-level profile node. Therefore, consider the deprecated warning
    to be irrelevant when the current profile node belongs to the same
    repo as the previous profile node.
    
    Bug: https://bugs.gentoo.org/753497
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 .../package/ebuild/_config/LocationsManager.py     | 30 ++++++++++++++++------
 .../package/ebuild/deprecated_profile_check.py     |  9 ++++---
 2 files changed, 27 insertions(+), 12 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2020-11-22 06:47:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b723fb347408dcd76ab4121f9cf94b0c51d48223

commit b723fb347408dcd76ab4121f9cf94b0c51d48223
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-11-22 06:43:39 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-11-22 06:47:30 +0000

    sys-apps/portage: Bump to version 3.0.10
    
     #753497 profiles should not inherit deprecated messages
     #754903 minimize use of installed packages to break cycles
     #755950 compare_files: handle missing xattr support
    
    Bug: https://bugs.gentoo.org/753497
    Bug: https://bugs.gentoo.org/754903
    Bug: https://bugs.gentoo.org/755950
    Bug: https://bugs.gentoo.org/756028
    Package-Manager: Portage-3.0.10, Repoman-3.0.2
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.10.ebuild | 267 +++++++++++++++++++++++++++++++++
 2 files changed, 268 insertions(+)