753098 – games-engines/love: migrate to lua eclasses

Bug 753098 - games-engines/love: migrate to lua eclasses

Summary: games-engines/love: migrate to lua eclasses

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Marek Szuba

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	slotted-lua
	Show dependency tree

Reported:	2020-11-04 10:38 UTC by Marek Szuba
Modified:	2020-11-16 12:40 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marek Szuba archtester

2020-11-04 10:38:06 UTC

Single-impl. Three different slots.

Comment 1 Marek Szuba archtester

2020-11-04 10:39:02 UTC

Fixed in commits: db335836b4a093827a84ae2b3d0995e4544b9663 (slot 0) and 945d6e4105745cd8c31b916e8e507bd8fb3d3f08 (legacy branches).

Comment 2 Marek Szuba archtester

2020-11-16 12:40:12 UTC

For the record, 11.3 does not build against lua5.4:

common/runtime.cpp: In function ‘int love::luax_resume(lua_State*, int)’:
common/runtime.cpp:969:37: error: too few arguments to function ‘int lua_resume(lua_State*, lua_State*, int, int*)’
  969 |  return lua_resume(L, nullptr, nargs);
      |                                     ^
In file included from common/runtime.h:32,
                 from common/runtime.cpp:22:
/usr/include/lua5.4/lua.h:300:15: note: declared here
  300 | LUA_API int  (lua_resume)     (lua_State *L, lua_State *from, int narg,
      |               ^~~~~~~~~~
make[3]: *** [Makefile:4863: common/runtime.lo] Error 1