In order for Gentoo Linux to properly support side-by-side installation of different versions of Lua (including LuaJIT), please migrate this package as to lua.eclass (for packages which should support multiple Lua implementations at the same time, i.e. most likely Lua modules) or lua-single.eclass (for packages which only have to support one Lua implementation at a time). For details, consult documentation of respective eclasses as well as already-migrated ebuilds in the tree. Please note that since slotted dev-lang/lua is currently masked, your migrated ebuilds should be masked as well. There is a section of package.mask, created in September 2020, which you can use for this purpose so that it will be easier in the future to unmask them all in one go. Thank you in advance for your effort!
This package doesn't install any lua scripts (these are provided by users in $HOME/.config/devilspie2), and only links with the library. It also explicitly wants lua5.1 and ignores presence of other versions (upstream is kind of dead, but package still useful). Does it still need the lua eclass? Is changing >=dev-lang/lua-5.1.5:0 to dev-lang/lua:5.1 sufficient? I can confirm that works, pulls right deps, builds, and runs fine.
(In reply to Ionen Wolkens from comment #1) > It also explicitly wants lua5.1 and ignores presence of other versions. Correction, it does check others but only if lua5.1 was not found. However it does it wrong and will fail. LIB_CFLAGS=$(shell pkg-config --cflags --silence-errors $(PKG_GTK) $(PKG_WNCK) lua5.1 || pkg-config --cflags $(PKG_GTK) $(PKG_WNCK) lua)
Ah, lua-utils.eclass has a solver for the above. Guess I'll test to see if it builds/runs with :5.2/5.3. I'll see if it works with those and might provide an updated ebuild myself.
Created attachment 669974 [details, diff] 0001-x11-misc-devilspie2-port-to-lua-single-eclass.patch Hope that's right, confirm seems to works with all of luajit+lua5-{1..3} (or at least with my scripts, no test suite) and links with right library. Feel free to use/modify/ignore as seen fit. ...and add >=x11-misc/devilspie2-0.43-r1 to package.mask (not included) I don't see any reason to keep devilspie2-0.42 if 0.43 is stabilized (no issues on my end), so haven't touched it. Newer lua may possibly break user scripts in $HOME (can't test those), but users can select a specific implementation if that's an issue. Also took the liberty to do minor unrelated cleanups: - guarded CC with "" - removed flag-o-matic inherit (unused) - replaced dodoc by einstalldocs (installs same things except skips the irrelevant VERSION file)
Created attachment 669977 [details, diff] 0001-x11-misc-devilspie2-port-to-lua-single-eclass.patch Unrelated to lua but realized the original ebuild specified DEPEND twice instead of DEPEND+BDEPEND, new version to fix this as well.
Created attachment 670073 [details, diff] 0001-x11-misc-devilspie2-port-to-lua-single-eclass-v3.patch Noticed forgot REQUIRED_USE looking at the example recently added to the eclass, so third version. Hope not missing anything else :) Been using it with luajit now, working fine.
I tested lua5-4 to see if worth adding, but 5-4 causes build failures -- so leaving patch unchanged. If need be I could fix the code but unless for 5-4 support becomes urgent I'll leave it alone (maybe upstream will wake up).
Thanks! I'll merge this shortly, the desktop-misc project has just been dissolved so this package is now effectively without a maintainer.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f69df3c1e7978b9bdca93b194a898d5baf239a2c commit f69df3c1e7978b9bdca93b194a898d5baf239a2c Author: Ionen Wolkens <sudinave@gmail.com> AuthorDate: 2020-11-05 14:46:50 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2020-11-29 19:42:02 +0000 x11-misc/devilspie2: port to lua-single eclass With some cosmetic changes made and package.mask entry added by Marek Szuba at merge time. Closes: https://bugs.gentoo.org/752885 Signed-off-by: Ionen Wolkens <sudinave@gmail.com> Signed-off-by: Marek Szuba <marecki@gentoo.org> profiles/package.mask | 1 + x11-misc/devilspie2/devilspie2-0.43-r100.ebuild | 48 ++++++++++++++++++++++ .../files/devilspie2-0.43-lua-pkgconfig.patch | 12 ++++++ 3 files changed, 61 insertions(+)
