Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752747 - media-gfx/gimp: migrate to lua eclasses
Summary: media-gfx/gimp: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 757873
  Show dependency tree
 
Reported: 2020-11-03 15:37 UTC by Marek Szuba
Modified: 2020-12-26 23:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gimp-2.99.2-r100.ebuild (gimp-2.99.2-r100.ebuild,6.55 KB, text/plain)
2020-12-22 23:01 UTC, Marek Szuba
Details
gimp-9999.ebuild (gimp-9999.ebuild,6.83 KB, text/plain)
2020-12-22 23:02 UTC, Marek Szuba
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:37:01 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Sergey Torokhov 2020-11-29 14:32:18 UTC
gimp-2.99.2 and -9999 currently require lua only in runtime and don't use lua to build plugins and extensions that are provided by gimp and just installed into package directory.

Lua presence is only checked on configuration phase. It seems that in this situation lua-single.eclass is suitable, isn't it?
Comment 2 Marek Szuba archtester gentoo-dev 2020-12-01 12:50:40 UTC
I would say you are correct. That's how I have treated most packages which do run-time Lua evaluation anyway.
Comment 3 Sergey Torokhov 2020-12-05 23:18:11 UTC
In some ported ebuilds I see LUA_COMPAT=( luajit ) but I don't see any information about this implementation in devmanual or directly within lua{,-single}.eclass code. 

@Marek Szuba could you please provide the url to description of that and "LUAJIT_*" etc?

The development gimp versions depend from dev-lang/luajit and dev-lua/lgi.
Comment 4 Marek Szuba archtester gentoo-dev 2020-12-22 16:12:21 UTC
If you look inside lua-utils.eclass you will find that luajit is in fact very much on the list of supported implementations. Not sure what else you need, IIRC the only difference between LuaJIT and other implementations as far as eclasses are concerned is that "luac" created by the wrapper is in fact /bin/true.
Comment 5 Marek Szuba archtester gentoo-dev 2020-12-22 23:01:21 UTC
Attaching migrated ebuilds, please review - especially the migration to EAPI-7, in particular the list of DEPEND atoms which should be moved to BDEPEND.
Comment 6 Marek Szuba archtester gentoo-dev 2020-12-22 23:01:56 UTC
Created attachment 679263 [details]
gimp-2.99.2-r100.ebuild
Comment 7 Marek Szuba archtester gentoo-dev 2020-12-22 23:02:48 UTC
Created attachment 679266 [details]
gimp-9999.ebuild
Comment 8 Marek Szuba archtester gentoo-dev 2020-12-22 23:04:06 UTC
Finally, moving this to the non-blocking tracker thanks to the fact neither of the lua-revdep GIMP ebuilds have any keywords.
Comment 9 Larry the Git Cow gentoo-dev 2020-12-26 23:18:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52b195c1624b27428e4fca190e0ab4316cf52d2d

commit 52b195c1624b27428e4fca190e0ab4316cf52d2d
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-12-26 22:15:10 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-12-26 23:18:19 +0000

    media-gfx/gimp/gimp: migrate to lua-single.eclass
    
    Latest 2.99 and the live ebuild; older versions do not depend on Lua.
    Approved by the maintainer via comment in the GitHub PR #18768.
    Also includes the requested Pango version bump in the dependencies of 9999.
    
    Closes: https://bugs.gentoo.org/752747
    Closes: https://bugs.gentoo.org/755962
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 media-gfx/gimp/gimp-2.99.2-r100.ebuild | 257 +++++++++++++++++++++++++++++++++
 media-gfx/gimp/gimp-9999.ebuild        |  32 ++--
 2 files changed, 277 insertions(+), 12 deletions(-)