Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752735 - kde-apps/cantor: migrate to lua eclasses
Summary: kde-apps/cantor: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 757873
  Show dependency tree
 
Reported: 2020-11-03 15:36 UTC by Marek Szuba
Modified: 2020-12-29 19:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba gentoo-dev 2020-11-03 15:36:56 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Andreas Sturmlechner gentoo-dev 2020-12-04 22:06:04 UTC
This is just using dev-lang/luajit:2. Should IUSE be renamed to luajit then?
Comment 2 Marek Szuba gentoo-dev 2020-12-22 16:09:10 UTC
Packages supporting only LuaJIT should also be migrated to lua-single.eclass, that said such packages do not of course block the unmasking of slotted dev-lang/lua. And IUSE=lua is not only fine but in fact recommended, as it hides the implementation details from users.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-28 16:00:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=005287b8721073d616f9aa294c81d7d32d0c44c7

commit 005287b8721073d616f9aa294c81d7d32d0c44c7
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-28 15:59:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-28 15:59:11 +0000

    kde-apps/cantor: Migrate to lua-single.eclass
    
    Bug: https://bugs.gentoo.org/752735
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/cantor/cantor-20.12.49.9999.ebuild | 14 ++++++++++----
 kde-apps/cantor/cantor-9999.ebuild          | 14 ++++++++++----
 2 files changed, 20 insertions(+), 8 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2020-12-29 19:54:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1316e9572318eef731d853e32bfae5ad15c648f3

commit 1316e9572318eef731d853e32bfae5ad15c648f3
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-12-28 15:59:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-12-29 19:54:07 +0000

    kde-apps/cantor: Migrate to lua-single.eclass
    
    Bug: https://bugs.gentoo.org/752735
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/cantor/cantor-20.12.0.ebuild | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)