Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752552 - app-i18n/ibus-libpinyin: migrate to lua eclasses
Summary: app-i18n/ibus-libpinyin: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Graham
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slotted-lua
  Show dependency tree
 
Reported: 2020-11-03 15:35 UTC by Marek Szuba
Modified: 2020-12-07 18:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:35:42 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-12-07 15:33:29 UTC
ibus-libpinyin 1.11.92 can be built with Lua 5.1, 5.2 and 5.3.
test-lua-plugin passes with Lua 5.1, 5.2 and 5.3.

ibus-libpinyin 1.11.92 fails to build with Lua 5.4:

> lmyoslib.c: In function ‘getfield’:
> lmyoslib.c:60:36: error: expected ‘)’ before ‘LUA_QS’
>    60 |       return luaL_error(L, "field " LUA_QS " missing in date table", key);
>       |                                    ^~~~~~~
>       |                                    )

Upstream already fixed this problem:
https://github.com/libpinyin/ibus-libpinyin/commit/f3faeeff3fbe3bf9e30ed4461c2c8d0466966e56

Fix is included in ibus-libpinyin >=1.11.93.
Comment 2 Larry the Git Cow gentoo-dev 2020-12-07 18:14:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b03759ae067d3714f2d3d52d36f8fbdf5a1c7dab

commit b03759ae067d3714f2d3d52d36f8fbdf5a1c7dab
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2020-12-07 04:00:00 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-12-07 18:14:27 +0000

    app-i18n/ibus-libpinyin: Use slotted Lua.
    
    Closes: https://bugs.gentoo.org/752552
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../ibus-libpinyin/ibus-libpinyin-1.11.92-r1.ebuild  | 20 ++++++++++++++------
 profiles/base/package.use.mask                       |  1 +
 2 files changed, 15 insertions(+), 6 deletions(-)