Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752120 - dev-libs/boost: is --no-cmake-config still needed?
Summary: dev-libs/boost: is --no-cmake-config still needed?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: David Seifert
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-11-01 15:24 UTC by Andrius Štikonas
Modified: 2021-05-26 22:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius Štikonas 2020-11-01 15:24:41 UTC
Is --no-cmake-config still needed in Gentoo ebuild?

https://github.com/boostorg/python/issues/262 seems to be resolved.

We hit this when
find_package(Boost "${Boost_MIN_VERSION}" CONFIG REQUIRED)
failed in libktorrent.

In upstream repo we have now switched to
find_package(Boost "${Boost_MIN_VERSION}" MODULE REQUIRED)
which works on Gentoo but maybe we can enable cmake config on Gentoo too.


Reproducible: Always
Comment 1 Christian Parpart 2021-05-03 10:32:09 UTC
Actually, I came here for the very same reason. I wanted to build Solidity compiler from source that does require cmake using find_package(Boost $BoostVersion COMPONENTS ... CONFIG REQUIRED) and was wondering why it keeps not finding it until I checked the ebuild file's contents.

I'd highly appreciate getting cmake module files installed. :)
Comment 2 Guilherme Amadio gentoo-dev 2021-05-11 12:59:50 UTC
I just tested with boost 1.76.0 and it doesn't seem to be needed anymore.
Since several packages use find_package(Boost CONFIG ...), we should re-enable installation of native CMake configuration files.
Comment 3 Guilherme Amadio gentoo-dev 2021-05-11 13:01:51 UTC
In particular, find_package(Boost CONFIG COMPONENTS python) fails in Gentoo, because that only works with the exported CMake configuration files. With CMake's own FindBoost.cmake, you need to specify a version, like python38.
Comment 4 Larry the Git Cow gentoo-dev 2021-05-19 12:36:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c8e363dbfd10f433f61425b325790db56ac365d

commit 8c8e363dbfd10f433f61425b325790db56ac365d
Author:     Guilherme Amadio <amadio@gentoo.org>
AuthorDate: 2021-05-18 10:57:40 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2021-05-19 12:18:37 +0000

    dev-libs/boost: remove workaround, bug #752120
    
    Installation of CMake configuration files when installing for multiple
    Python versions has been fixed upstream, so the workaround is no longer
    necessary. Installation of CMake files is required to make calls like
    find_package(Boost CONFIG) and find_package(Boost COMPONENTS python) work.
    
    Closes: https://bugs.gentoo.org/752120
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

 dev-libs/boost/{boost-1.76.0.ebuild => boost-1.76.0-r1.ebuild} | 4 ----
 1 file changed, 4 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2021-05-26 22:08:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a328594c9f92c46af48cc064943f086bc2a07ce8

commit a328594c9f92c46af48cc064943f086bc2a07ce8
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-05-26 22:07:17 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-05-26 22:08:14 +0000

    dev-util/schroot: pass -DBoost_NO_BOOST_CMAKE=ON
    
    Bug: https://bugs.gentoo.org/752120
    Closes: https://bugs.gentoo.org/791712
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-util/schroot/schroot-1.6.10_p12.ebuild | 2 +-
 dev-util/schroot/schroot-1.6.10_p7.ebuild  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)