Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752021 - app-office/libreoffice-6.4.7.2 fails to build against dev-libs/icu-68.1
Summary: app-office/libreoffice-6.4.7.2 fails to build against dev-libs/icu-68.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: icu-68.1
  Show dependency tree
 
Reported: 2020-10-31 12:21 UTC by Mike Lothian
Modified: 2020-11-06 02:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libreoffice-6.4.7.2-icu.patch (libreoffice-6.4.7.2-icu.patch,1.26 KB, patch)
2020-10-31 12:23 UTC, Mike Lothian
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lothian 2020-10-31 12:21:23 UTC
The build fails as it used the now deprecated TRUE/FALSE rather than true/false

Patch that gets things working for me attached

I use the following USE flags:

USE="bluetooth branding cups dbus googledrive gstreamer gtk java mariadb pdfimport"

Reproducible: Always
Comment 1 Mike Lothian 2020-10-31 12:23:04 UTC
Created attachment 669425 [details, diff]
libreoffice-6.4.7.2-icu.patch
Comment 2 Andreas Sturmlechner gentoo-dev 2020-10-31 18:03:51 UTC
Thanks for your contribution, could you submit this to upstream's gerrit instance?
Comment 3 Perfect Gentleman 2020-11-01 17:39:38 UTC
(In reply to Mike Lothian from comment #1)
> Created attachment 669425 [details, diff] [details, diff]
> libreoffice-6.4.7.2-icu.patch

thanx. first part works for LO-7
Comment 5 Larry the Git Cow gentoo-dev 2020-11-05 22:51:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d05d533d5040c87b379b924f87b335963b92259f

commit d05d533d5040c87b379b924f87b335963b92259f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-11-05 21:00:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-11-05 22:50:54 +0000

    app-office/libreoffice: Fix build with ICU-68
    
    Upstream commit 0b14b9ec55fb2a8dd0ec24e1c03702bc4bbf1878
    
    Reported-by: Mike Lothian <mike@fireburn.co.uk>
    Closes: https://bugs.gentoo.org/752021
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/libreoffice-6.4.7.2-icu-68.patch         | 46 ++++++++++++++++++++++
 app-office/libreoffice/libreoffice-6.4.7.2.ebuild  |  1 +
 2 files changed, 47 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2020-11-06 02:22:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6229e6d13f5af9ecc6a437e6218cca9cd5f96056

commit 6229e6d13f5af9ecc6a437e6218cca9cd5f96056
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-11-06 01:55:57 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-11-06 02:21:53 +0000

    app-office/libreoffice: Add second part of ICU-68 fix
    
    Not part of upstream's ICU-68 commit 0b14b9ec because it was already changed
    to use standard true in git master and libreoffice-7-0 branch beforehand.
    
    Thanks-to: Mike Lothian <mike@fireburn.co.uk>
    Closes: https://bugs.gentoo.org/752021
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 ...68.patch => libreoffice-6.4.7.2-icu-68-1.patch} |  0
 .../files/libreoffice-6.4.7.2-icu-68-2.patch       | 28 ++++++++++++++++++++++
 app-office/libreoffice/libreoffice-6.4.7.2.ebuild  |  2 +-
 3 files changed, 29 insertions(+), 1 deletion(-)