Bug 751997 – dev-qt/qtwebengine fails to build with =dev-libs/icu-68.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lars Wendler (Polynomial-C) (RETIRED) 2020-10-31 08:41:22 UTC]

Created attachment 669389 [details, diff]
qtwebengine-5.15.1-icu68.patch

This is just one example how the package fails to build:

FAILED: obj/base/i18n/time_formatting.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -MMD -MF obj/base/i18n/time_formatting.o.d -DBASE_I18N_IMPLEMENTATION -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -DTOOLKIT_QT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DUCHAR_TYPE=uint16_t -Igen -I../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium -Igen -Igen -Igen -I../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium/third_party/ced/src -I../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium/third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -m64 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-packed-not-aligned -Wno-dangling-else -Wno-missing-field-initializers -Wno-unused-parameter -fno-omit-frame-pointer -g0 -fvisibility=hidden -O2 -fno-ident -fdata-sections -ffunction-sections -std=gnu++14 -Wno-narrowing -Wno-class-memaccess -Wno-attributes -Wno-class-memaccess -Wno-subobject-linkage -Wno-invalid-offsetof -Wno-return-type -Wno-deprecated-copy -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium/base/i18n/time_formatting.cc -o obj/base/i18n/time_formatting.o
../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium/base/i18n/time_formatting.cc: In function ‘bool base::TimeDurationFormatWithSeconds(base::TimeDelta, base::DurationFormatWidth, base::string16*)’:
../../../../qtwebengine-everywhere-src-5.15.1/src/3rdparty/chromium/base/i18n/time_formatting.cc:239:31: error: ‘TRUE’ was not declared in this scope
  239 |   return U_SUCCESS(status) == TRUE;
      |                               ^~~~
[4472/18305] ACTION //third_party/blink/renderer/bindings/modules/v8:bindings_modules_origin_trial_features(/var/tmp/portage/dev-qt/qtwebengine-5.15.1/work/qtwe[4474/18305] ACTION //third_party/devtools-frontend/src:supported_css_properties(/var/tmp/portage/dev-qt/qtwebengine-5.15.1/work/qtwebengine-everywhere-src-5.15[4475/18305] ACTION //third_party/blink/renderer/bindings/modules/v8:generate_v8_context_snapshot_external_references(/var/tmp/portage/dev-qt/qtwebengine-5.15.1[4476/18305] ACTION //third_party/blink/renderer/bindings/core/v8:generate_bindings_core_v8_interfaces(/var/tmp/portage/dev-qt/qtwebengine-5.15.1/work/qtwebengi[4477/18305] ACTION //third_party/blink/renderer/bindings/modules/v8:generate_bindings_modules_v8_interfaces(/var/tmp/portage/dev-qt/qtwebengine-5.15.1/work/qtwebengine-everywhere-src-5.15.1_build/src/toolchain:target)
ninja: build stopped: subcommand failed.
make[3]: *** [Makefile.gn_run:717: run_ninja] Error 1

[Comment 1 Chiitoo 2020-11-03 01:32:29 UTC]

Thanks!

I'm on 5.15.9999 where the patch will look a bit different already (sent upstream [1]), so I haven't actually tried this one personally, but it looks good.

1. https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/320096

[Comment 2 Larry the Git Cow 2020-11-05 22:51:09 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d8735081918c2351c73b9b4ce41148a8d124653

commit 9d8735081918c2351c73b9b4ce41148a8d124653
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2020-11-05 21:01:58 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2020-11-05 22:50:56 +0000

    dev-qt/qtwebengine: Fix build with ICU-68
    
    Thanks-to: Lars Wendler <[e-mail]>
    Closes: https://bugs.gentoo.org/751997
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../files/qtwebengine-5.15.1-icu-68.patch          | 260 +++++++++++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.15.1.ebuild       |   5 +-
 2 files changed, 264 insertions(+), 1 deletion(-)