Created attachment 669317 [details, diff] libxml2-2.9.10-icu68.patch libtool: compile: x86_64-pc-linux-gnu-gcc -m32 -DHAVE_CONFIG_H -I. -I/var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10 -I./include -I/var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10/include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls -Wno-long-long -Wno-format-extra-args -D_REENTRANT -march=native -mtune=native -O2 -pipe -c /var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10/encoding.c -fPIC -DPIC -o .libs/encoding.o /var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10/encoding.c: In function ‘xmlEncOutputChunk’: /var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10/encoding.c:1966:31: error: ‘TRUE’ undeclared (first use in this function) 1966 | TRUE); | ^~~~ /var/tmp/portage/dev-libs/libxml2-2.9.10-r3/work/libxml2-2.9.10/encoding.c:1966:31: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [Makefile:1292: encoding.lo] Error 1
I looked and didn't see any upstream changes to this code, so there's no patch to pull. The TRUE/FALSE definitions indicate something about the need for compatibility with pre-C99 platforms. I think the patch is fine as you have it. Feel free to commit. Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ffcf01ad268f711faa94fcb5f7d5b3e22ad4a567 commit ffcf01ad268f711faa94fcb5f7d5b3e22ad4a567 Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2020-10-30 22:27:50 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2020-10-30 22:33:53 +0000 dev-libs/libxml2: Add patch to fix build with icu-68.1 Closes: https://bugs.gentoo.org/751922 Signed-off-by: Matt Turner <mattst88@gentoo.org> .../libxml2/files/libxml2-2.9.10-remove-TRUE.patch | 31 ++++++++++++++++++++++ dev-libs/libxml2/libxml2-2.9.10-r3.ebuild | 2 ++ 2 files changed, 33 insertions(+)
