751385 – net-analyzer/wireshark-3.4.0_rc1[tfshark] cannot compile

Bug 751385 - net-analyzer/wireshark-3.4.0_rc1[tfshark] cannot compile

Summary: net-analyzer/wireshark-3.4.0_rc1[tfshark] cannot compile

Status:	RESOLVED DUPLICATE of bug 751358

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Netmon project

URL:	https://gitlab.com/wireshark/wireshar...
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2020-10-26 19:27 UTC by PhobosK
Modified:	2020-10-26 20:31 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
tfshark_urls.patch (tfshark_urls.patch,359 bytes, patch) 2020-10-26 19:29 UTC, PhobosK	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description PhobosK 2020-10-26 19:27:56 UTC

The compilation of net-analyzer/wireshark-3.4.0_rc1[tfshark] gives an error:

FAILED: CMakeFiles/tfshark.dir/tfshark.c.o 
/usr/bin/x86_64-pc-linux-gnu-gcc -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DHAVE_PLUGINS -I. -I/dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0rc1 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include  -fvisibility=hidden  -fexcess-precision=fast -Wall -Wextra -Wendif-labels -Wpointer-arith -Wformat-security -fwrapv -fno-strict-overflow -Wvla -Waddress -Wattributes -Wdiv-by-zero -Wignored-qualifiers -Wpragmas -Wno-overlength-strings -Wno-long-long -Wframe-larger-than=32768 -Wc++-compat -Wunused-const-variable -Wshadow -Wold-style-definition -Wstrict-prototypes -Wlogical-op -Wjump-misses-init -Werror=implicit -Wno-pointer-sign -std=gnu99 -march=native -O2 -pipe -fmacro-prefix-map=/dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0rc1/= -fmacro-prefix-map=/dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0_rc1_build/= -fPIE -MD -MT CMakeFiles/tfshark.dir/tfshark.c.o -MF CMakeFiles/tfshark.dir/tfshark.c.o.d -o CMakeFiles/tfshark.dir/tfshark.c.o -c /dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0rc1/tfshark.c
/dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0rc1/tfshark.c: In function ‘main’:
/dev/shm/portage/net-analyzer/wireshark-3.4.0_rc1/work/wireshark-3.4.0rc1/tfshark.c:951:31: error: expected ‘)’ before ‘WS_WIKI_URL’
  951 |             "Out Of Memory.\n"
      |                               ^
      |                               )
......
  956 |              WS_WIKI_URL("KnownBugs/OutOfMemory") "\n");
      |              ~~~~~~~~~~~       
ninja: build stopped: subcommand failed.


This is an upstream error, was reported upstream and they fixed it. 
Here is the upstream fix commit: https://gitlab.com/wireshark/wireshark/-/commit/a8d023ba581bab311e58dce13706125b28271535


I am uploading the upstream patch.
When applied as user patch in /etc/portage/patches/net-analyzer/wireshark-3.4.0_rc1 it fixes the problem with the tfshark IUSE flag enabled

You may add it to the portage tree :)

Thanks

Reproducible: Always

Comment 1 PhobosK 2020-10-26 19:29:43 UTC

Created attachment 668738 [details, diff]
tfshark_urls.patch

The actual upstream patch fixing the problem

Comment 2 Sam James archtester

2020-10-26 20:31:08 UTC


*** This bug has been marked as a duplicate of bug 751358 ***