Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 750707 - gui-apps/gtkgreet-0.6-r1 uses -Werror for build
Summary: gui-apps/gtkgreet-0.6-r1 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aisha Tammy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2020-10-22 05:55 UTC by Agostino Sarubbo
Modified: 2020-11-13 21:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-10-22 05:55:08 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-apps/gtkgreet-0.6-r1 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Larry the Git Cow gentoo-dev 2020-11-13 21:26:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=982f94041641d9900756f59cabafddd380e66e5a

commit 982f94041641d9900756f59cabafddd380e66e5a
Author:     Aisha Tammy <gentoo@aisha.cc>
AuthorDate: 2020-10-30 15:52:40 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-11-13 21:26:06 +0000

    gui-apps/gtkgreet: remove Werror build flag
    
    Closes: https://bugs.gentoo.org/750707
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Aisha Tammy <gentoo@aisha.cc>
    Closes: https://github.com/gentoo/gentoo/pull/18077
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 gui-apps/gtkgreet/files/gtkgreet-0.6-r1-werror.patch | 12 ++++++++++++
 gui-apps/gtkgreet/gtkgreet-0.6-r1.ebuild             |  7 ++++---
 gui-apps/gtkgreet/gtkgreet-9999.ebuild               |  2 ++
 3 files changed, 18 insertions(+), 3 deletions(-)